DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3384223CB
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 8B25D6020B
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Joe Perches <joe@perches.com>
Cc:     yhchuang@realtek.com, Larry.Finger@lwfinger.net,
        pkshih@realtek.com, tehuang@realtek.com, sgruszka@redhat.com,
        johannes@sipsolutions.net, linux-wireless@vger.kernel.org
Subject: Re: [RFC v4 08/13] rtw88: debug files
References: <1539421245-11847-1-git-send-email-yhchuang@realtek.com>
        <1539421245-11847-9-git-send-email-yhchuang@realtek.com>
        <a731948bf875867be4246b72a661ce71833620b8.camel@perches.com>
        <87y3b1vpjk.fsf@codeaurora.org>
        <0a41d14b9a964b6b7825bf5c55c32f35166354cd.camel@perches.com>
        <e85b7fa45cefc0bc3df15785f34792abe33f41c6.camel@perches.com>
        <878t1ubf6i.fsf@codeaurora.org>
        <3946d05c0c026f3bdffaa35a686e5f12b8f3c59e.camel@perches.com>
Date:   Thu, 15 Nov 2018 18:08:23 +0200
In-Reply-To: <3946d05c0c026f3bdffaa35a686e5f12b8f3c59e.camel@perches.com> (Joe
        Perches's message of "Thu, 15 Nov 2018 07:19:56 -0800")
Message-ID: <87zhua8gso.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Joe Perches <joe@perches.com> writes:

> On Thu, 2018-11-15 at 16:15 +0200, Kalle Valo wrote:
>> Joe Perches <joe@perches.com> writes:
>> 
>> > On Sat, 2018-10-13 at 13:28 -0700, Joe Perches wrote:
>> > > On Sat, 2018-10-13 at 18:23 +0300, Kalle Valo wrote:
>> > > > Joe Perches <joe@perches.com> writes:
>> > []
>> > > > > It's very unusual to have _all_ the logging under a CONFIG_<FOO>_DEBUG
>> > > > > config guard flag.
>> > > > 
>> > > > For wireless drivers that is actually quite typical.
>> > > 
>> > > No, it isn't.
>> > > 
>> > > > IIRC at least ath6kl, ath9k and ath10k do that, most likely also others.
>> > > 
>> > > No, they don't.  Check again.
> []
>> > Kalle, did I miss a reply here?
>> 
>> I didn't bother to waste my time after reading comments like "check
>> again" and "look harder".
>
> You are the maintainer here and you give advice that others are
> likely to follow.
>
> I was a bit frustrated after your fairly assertive, but wrong
> statement that the other drivers you maintain do the same thing.

Yeah, I can understand that. But do note that I'm a non-native english
speaker with an always full inbox, I don't have time nor skills to write
in a way expected by a native speaker. So please don't assume that I'm
assertive or other meanings from my style of text, just consider that my
writings as "simple english".

Also I do a lot of mistakes, and when I do please just clearly explain
it to me. I'm always grateful about that, all constructive help is very
welcome.

-- 
Kalle Valo