DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA97620671
Date:   Mon, 19 Nov 2018 18:10:16 +0000
From:   Priit Laes <plaes@plaes.org>
To:     Larry Finger <Larry.Finger@lwfinger.net>,
        Jia-Ju Bai <baijiaju1990@gmail.com>,
        Kalle Valo <kvalo@codeaurora.org>,
        Kees Cook <keescook@chromium.org>,
        "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
        Colin Ian King <colin.king@canonical.com>,
        Arend van Spriel <arend.vanspriel@broadcom.com>,
        Varsha Rao <rvarsha016@gmail.com>,
        linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org
Subject: Re: [PATCH 0/4] wireless: Use common cordic algorithm for b43 driver
Message-ID: <20181119181016.4fxuszvvyiokuqvl@plaes.org>
References: <cover.87f16ede7954f8d9cde4ecae5f050bf8f4008dd8.1542649316.git-series.plaes@plaes.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.87f16ede7954f8d9cde4ecae5f050bf8f4008dd8.1542649316.git-series.plaes@plaes.org>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Mon, Nov 19, 2018 at 08:01:21PM +0200, Priit Laes wrote:
> b43 wireless driver includes an internal implementation of
> cordic algorithm, although there's a common cordic library
> which was split out from brcmsmac driver. Use that and drop
> internal implementation.
> 
> During the process, cordic-algorithm related macros in
> brcmfmac driver were also removed and use general macros.
> 
> Please note that this series is only compile-tested, as I
> do not have access to the hardware.


Gah.. I missed the series version in subject. Shall I resend?

> 
> --
> 
> Changes since v3:
> - Added ACKed-By bits for patches 1, 4
> - Added new patch for stable by Larry as patch 3
> - Fixed argument scaling for b43 driver in patch 4
> 
> Changes since v2:
> - Improvements to commit messages. No functional changes.
> - Collect reviewed-by bits.
> 
> Changes since v1:
> - Merged brcmsmac driver patches into single patch
> - Merged b43 driver patches into single patch
> 
> Larry Finger (1):
>   b43: Fix error in cordic routine
> 
> Priit Laes (3):
>   lib: cordic: Move cordic macros and defines to header file
>   brcmsmac: Use cordic-related macros from common cordic library
>   b43: Use cordic algorithm from kernel library
> 
>  drivers/net/wireless/broadcom/b43/Kconfig                      |  1 +-
>  drivers/net/wireless/broadcom/b43/phy_common.c                 | 47 +-------
>  drivers/net/wireless/broadcom/b43/phy_common.h                 |  9 +-
>  drivers/net/wireless/broadcom/b43/phy_lp.c                     | 13 +-
>  drivers/net/wireless/broadcom/b43/phy_n.c                      | 13 +-
>  drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_int.h |  7 +-
>  drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c |  4 +-
>  drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c   |  4 +-
>  include/linux/cordic.h                                         |  9 +-
>  lib/cordic.c                                                   | 23 +---
>  10 files changed, 35 insertions(+), 95 deletions(-)
> 
> base-commit: 9ff01193a20d391e8dbce4403dd5ef87c7eaaca6
> -- 
> git-series 0.9.1