DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9718D20663
MIME-Version: 1.0
References: <20181129042522.11767-1-govinds@codeaurora.org>
In-Reply-To: <20181129042522.11767-1-govinds@codeaurora.org>
From:   Brian Norris <briannorris@chromium.org>
Date:   Fri, 30 Nov 2018 12:59:49 -0800
Message-ID: <CA+ASDXMOqzXk9HrX9AS58cUfKOHeXA7zN_ME3+zDZXQcok_0Tg@mail.gmail.com>
Subject: Re: [PATCH] ath10k: Move non-fatal warn logs to dbg level
To:     govinds@codeaurora.org
Cc:     ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Wed, Nov 28, 2018 at 8:25 PM Govind Singh <govinds@codeaurora.org> wrote:
>
> During driver load below warn logs are printed in the console.
> Since driver may not implement all wmi events sent by fw and
> all of them are non-fatal, move this log to debug level to
> remove un-necessary warn message on console.
>
> [  361.887230] ath10k_snoc a000000.wifi: Unknown eventid: 16393
> [  361.907037] ath10k_snoc a000000.wifi: Unknown eventid: 237569
>
> Signed-off-by: Govind Singh <govinds@codeaurora.org>

Alternatively, you could add these ignored commands to wmi-tlv.h, and
just ignore them specifically. That's better documentation, in case
new WMI events come along that *are* important to notice when we
ignore them. There are other recent examples of that sort of patch
being merged.

Brian