Subject: Re: [PATCH] brcmfmac: Fix access point mode
To:     Stefan Wahren <stefan.wahren@i2se.com>,
        Franky Lin <franky.lin@broadcom.com>,
        Hante Meuleman <hante.meuleman@broadcom.com>,
        Chi-Hsien Lin <chi-hsien.lin@cypress.com>,
        Wright Feng <wright.feng@cypress.com>
Cc:     Kalle Valo <kvalo@codeaurora.org>,
        =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>,
        linux-wireless@vger.kernel.org,
        brcm80211-dev-list.pdl@broadcom.com,
        brcm80211-dev-list@cypress.com, netdev@vger.kernel.org
References: <1544642406-24272-1-git-send-email-stefan.wahren@i2se.com>
From:   Arend Van Spriel <arend.vanspriel@broadcom.com>
Message-ID: <e0a0b249-eb3e-7284-1a99-1c4fc5683850@broadcom.com>
Date:   Sat, 15 Dec 2018 12:06:56 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.3
MIME-Version: 1.0
In-Reply-To: <1544642406-24272-1-git-send-email-stefan.wahren@i2se.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 12/12/2018 8:20 PM, Stefan Wahren wrote:
> Since commit 1204aa17f3b4 ("brcmfmac: set WIPHY_FLAG_HAVE_AP_SME flag")
> the Raspberry Pi 3 A+ (BCM43455) isn't able to operate in AP mode with
> hostapd (device_ap_sme=1 use_monitor=0):
> 
> brcmfmac: brcmf_cfg80211_stop_ap: setting AP mode failed -52
> 
> So add the missing mgmt_stypes for AP mode to fix this.
> 
> Fixes: 1204aa17f3b4 ("brcmfmac: set WIPHY_FLAG_HAVE_AP_SME flag")
> Suggested-by: Arend van Spriel <arend.vanspriel@broadcom.com>

Thanks for submitting this patch.

Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
>   drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> index 7f0a5ba..05bd818 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> @@ -6309,6 +6309,16 @@ brcmf_txrx_stypes[NUM_NL80211_IFTYPES] = {
>   		.tx = 0xffff,
>   		.rx = BIT(IEEE80211_STYPE_ACTION >> 4) |
>   		      BIT(IEEE80211_STYPE_PROBE_REQ >> 4)
> +	},
> +	[NL80211_IFTYPE_AP] = {
> +		.tx = 0xffff,
> +		.rx = BIT(IEEE80211_STYPE_ASSOC_REQ >> 4) |
> +		      BIT(IEEE80211_STYPE_REASSOC_REQ >> 4) |
> +		      BIT(IEEE80211_STYPE_PROBE_REQ >> 4) |
> +		      BIT(IEEE80211_STYPE_DISASSOC >> 4) |
> +		      BIT(IEEE80211_STYPE_AUTH >> 4) |
> +		      BIT(IEEE80211_STYPE_DEAUTH >> 4) |
> +		      BIT(IEEE80211_STYPE_ACTION >> 4)
>   	}
>   };
>   
>