Message-ID: <89e6532daf4011de2ad0df3dcb8accc42334f31e.camel@sipsolutions.net>
Subject: Re: [PATCH] nl80211/cfg80211: Add support to send tx frames at
 specified rate
From:   Johannes Berg <johannes@sipsolutions.net>
To:     vamsi krishna <vamsin@codeaurora.org>
Cc:     linux-wireless@vger.kernel.org, jouni@codeaurora.org
Date:   Tue, 18 Dec 2018 14:12:23 +0100
In-Reply-To: <1543838646-3574-1-git-send-email-vamsin@codeaurora.org>
References: <1543838646-3574-1-git-send-email-vamsin@codeaurora.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Mon, 2018-12-03 at 17:34 +0530, vamsi krishna wrote:
> NL80211_CMD_FRAME is used to send frames from userspace. Add support to
> transmit the frames at a rate specified by userspace when needed.
> The drivers shall indicate the support to send frames at rate specified
> by userspace by setting %NL80211_EXT_FEATURE_CMD_FRAME_TXRATE flag in
> wiphy capabilities. The userspace can specify the rate within
> %NL80211_ATTR_RATE_INFO attribute while sending %NL80211_CMD_FRAME.
> 
> NL80211_ATTR_RATE_INFO is a nested attribute and encapsulates the
> attributes defined in &enum nl80211_rate_info.

It'd be good if you were to repost this with a driver that uses it.

Also, please explain why you think userspace needs this? It's not like
it can make better rate decisions than the rate control algorithm,
right?

>  	[NL80211_ATTR_SCHED_SCAN_MIN_RSSI] = { .type = NLA_NESTED },
> +	[NL80211_ATTR_RATE_INFO] = { .type = NLA_NESTED },

This should use NLA_POLICY_NESTED(nl80211_rate_info_policy)

johannes