From:   "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>
To:     Kalle Valo <kvalo@codeaurora.org>,
        Stephen Rothwell <sfr@canb.auug.org.au>
CC:     Wireless <linux-wireless@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "Sharon, Sara" <sara.sharon@intel.com>,
        "Coelho, Luciano" <luciano.coelho@intel.com>,
        Kees Cook <keescook@google.com>,
        "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
        "David Miller" <davem@davemloft.net>,
        Networking <netdev@vger.kernel.org>
Subject: RE: linux-next: build warnings after merge of the
 wireless-drivers-next tree
Thread-Topic: linux-next: build warnings after merge of the
 wireless-drivers-next tree
Thread-Index: AQHUl2/DznSNsdWt3UCII8zN8RybjKWFu5lQ
Date:   Wed, 19 Dec 2018 08:31:54 +0000
Message-ID: <0BA3FCBA62E2DC44AF3030971E174FB3013375F96C@HASMSX112.ger.corp.intel.com>
References: <20181130120555.1d35eb6b@canb.auug.org.au>
        <20181219134738.4efed34f@canb.auug.org.au>
 <871s6evtra.fsf@kamboji.qca.qualcomm.com>
In-Reply-To: <871s6evtra.fsf@kamboji.qca.qualcomm.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.0.600.7
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

> 
> Stephen Rothwell <sfr@canb.auug.org.au> writes:
> 
> > On Fri, 30 Nov 2018 12:05:55 +1100 Stephen Rothwell
> <sfr@canb.auug.org.au> wrote:
> >>
> >> After merging the wireless-drivers-next tree, today's linux-next
> >> build
> >> (x86_64 allmodconfig) produced these warnings:
> >>
> >> drivers/net/wireless/intel/iwlwifi/iwl-drv.c: In function
> 'iwl_parse_tlv_firmware':
> >> drivers/net/wireless/intel/iwlwifi/iwl-drv.c:1098:7: warning: this
> statement may fall through [-Wimplicit-fallthrough=]
> >>     if (iwlwifi_mod_params.enable_ini)
> >>        ^
> >> drivers/net/wireless/intel/iwlwifi/iwl-drv.c:1100:3: note: here
> >>    default:
> >>    ^~~~~~~
> >> drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c: In function
> 'iwl_parse_fw_dbg_tlv':
> >> drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c:203:4: warning: this
> statement may fall through [-Wimplicit-fallthrough=]
> >>     iwl_fw_dbg_copy_tlv(trans, tlv, true);
> >>     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >> drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c:204:3: note: here
> >>    default:
> >>    ^~~~~~~
> >>
> >> Introduced by commit
> >>
> >>   f14cda6f3b31 ("iwlwifi: trans: parse and store debug ini TLVs")
> >>
> >> These are noted because I use -Wimplict-fallthrough
> >>
> >> The warnings can be suppressed by adding a comment like
> >> 	/* fall through */
> >> at the appropriate place to indicate that the fallthough is intended.
> >
> > I am still seeing these warnings (but in the net-next tree now) and I
> > do not see a fix patch in the wireless-drivers-next tree.
> 
> Luca did submit a patch[1] for cfg80211 to fix those but I don't see any
> patches for iwlwifi (even in the one pending pull request he sent), not sure
> what happened. I know that Luca is already on holidays but adding
> Emmanuel, maybe he can help here?
> 

Just sent a patch.