Message-ID: <43f69cb7ddc44d4c1f9a12b729c9319066e981c0.camel@sipsolutions.net>
Subject: Re: [PATCH] cfg80211: Allow drivers to advertise supported AKM
 suites
From:   Johannes Berg <johannes@sipsolutions.net>
To:     vjakkam@codeaurora.org
Cc:     linux-wireless@vger.kernel.org
Date:   Wed, 19 Dec 2018 21:42:14 +0100
In-Reply-To: <e9f26148a73c5b10192fd12c61d76f14@codeaurora.org>
References: <1542368582-3153-1-git-send-email-vjakkam@codeaurora.org>
         <898d521150250b33b9c1efa42e63efc4bf608e06.camel@sipsolutions.net>
         <e9f26148a73c5b10192fd12c61d76f14@codeaurora.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Wed, 2018-12-19 at 17:59 +0530, vjakkam@codeaurora.org wrote:
> On 2018-12-18 18:35, Johannes Berg wrote:
> > On Fri, 2018-11-16 at 17:13 +0530, Veerendranath Jakkam wrote:
> > > There was no such capability advertisement from the driver and thus 
> > > the
> > > current user space has to assume the driver to support all the AKMs. 
> > > While
> > > that may be the case with some drivers (e.g., mac80211-based ones), 
> > > there
> > > are cfg80211-based drivers that have constraints on which AKMs can be 
> > > used.
> > > Allow such drivers to advertise the exact set of supported AKMs so 
> > > that
> > > user space tools can determine what network profile options should be
> > > allowed to be configured.
> > 
> > I think you need to explain here (and probably also in the docs) where
> > this actually matters. Clearly with drivers that do it all in userspace
> > it doesn't matter - so I guess it's intended for the offload cases?
> > 
> > Also, it'd be good to know which driver needs/implements this.
> 
> This is required by the Wi-Fi driver/solution , where the SME is part of
> the driver and does not define separate commands for authentication and
> association. The driver we are targeting here is specific to Qualcomm
> and the design needs update to support new AKM's. (For EX,this driver
> needs an enhancement to trigger NL80211_CMD_EXTERNAL_AUTH for SAE AKM).

This may be a bit repetitive ... but when are we going to see this
driver upstream? :-)

We keep adding APIs like this that you cannot actually use upstream,
which doesn't make me feel all that good about them.

johannes