DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org BC9F960208
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Brian Norris <briannorris@chromium.org>
Cc:     govinds@codeaurora.org, linux-wireless@vger.kernel.org,
        ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: Move non-fatal warn logs to dbg level
References: <20181129042522.11767-1-govinds@codeaurora.org>
        <CA+ASDXMOqzXk9HrX9AS58cUfKOHeXA7zN_ME3+zDZXQcok_0Tg@mail.gmail.com>
Date:   Thu, 20 Dec 2018 18:40:43 +0200
In-Reply-To: <CA+ASDXMOqzXk9HrX9AS58cUfKOHeXA7zN_ME3+zDZXQcok_0Tg@mail.gmail.com>
        (Brian Norris's message of "Fri, 30 Nov 2018 12:59:49 -0800")
Message-ID: <87h8f8talw.fsf@kamboji.qca.qualcomm.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Brian Norris <briannorris@chromium.org> writes:

> On Wed, Nov 28, 2018 at 8:25 PM Govind Singh <govinds@codeaurora.org> wrote:
>>
>> During driver load below warn logs are printed in the console.
>> Since driver may not implement all wmi events sent by fw and
>> all of them are non-fatal, move this log to debug level to
>> remove un-necessary warn message on console.
>>
>> [  361.887230] ath10k_snoc a000000.wifi: Unknown eventid: 16393
>> [  361.907037] ath10k_snoc a000000.wifi: Unknown eventid: 237569
>>
>> Signed-off-by: Govind Singh <govinds@codeaurora.org>
>
> Alternatively, you could add these ignored commands to wmi-tlv.h, and
> just ignore them specifically. That's better documentation, in case
> new WMI events come along that *are* important to notice when we
> ignore them. There are other recent examples of that sort of patch
> being merged.

I have actually tried to do that (what Brian describes above) during the
last years but the problem is that there are just so many different
firmware branches that it's difficult to keep up in ath10k. So in the
end these warnings just confused the users and they mistakenly thought
this warning message is the cause of their problems. That's why I think
it's best to remove this warning.

-- 
Kalle Valo