MIME-Version: 1.0
References: <1546501565-40752-1-git-send-email-chi-hsien.lin@cypress.com> <1546501565-40752-2-git-send-email-chi-hsien.lin@cypress.com>
In-Reply-To: <1546501565-40752-2-git-send-email-chi-hsien.lin@cypress.com>
From:   James Hughes <james.hughes@raspberrypi.org>
Date:   Thu, 3 Jan 2019 09:56:14 +0000
Message-ID: <CAE_XsM+mdHkwMF3PEimVJBpLd=oMmuvK1uDdA7y8uJT8hYNfbA@mail.gmail.com>
Subject: Re: [PATCH 1/2] brcmfmac: fix system warning message during wowl suspend
To:     Chi-Hsien Lin <Chi-Hsien.Lin@cypress.com>
Cc:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "brcm80211-dev-list@broadcom.com" <brcm80211-dev-list@broadcom.com>,
        brcm80211-dev-list <brcm80211-dev-list@cypress.com>,
        Arend van Spriel <arend.vanspriel@broadcom.com>,
        Franky Lin <franky.lin@broadcom.com>,
        Hante Meuleman <hante.meuleman@broadcom.com>,
        Wright Feng <Wright.Feng@cypress.com>,
        Kalle Valo <kvalo@codeaurora.org>,
        Double Lo <Double.Lo@cypress.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Thu, 3 Jan 2019 at 07:46, Chi-Hsien Lin <Chi-Hsien.Lin@cypress.com> wrote:
>
> From: Lo-Hsiang Lo <double.lo@cypress.com>
>
> There is a system warning message, warn_slowpath-fmt, during suspend
> while using supplicant join AP and enable wowl feature by IW command.
> It's cuased by brcmf_pno_remove_request path can't find the reqid.
> This fix will not go to remove pno request function if there is no
> pno scan.

Typo in the commit message `cuased`

>
> Signed-off-by: Lo-Hsiang Lo <double.lo@cypress.com>
> Signed-off-by: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
> ---
>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/pno.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pno.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pno.c
> index ffa243e2e2d0..55974a43796a 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pno.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pno.c
> @@ -496,6 +496,11 @@ int brcmf_pno_stop_sched_scan(struct brcmf_if *ifp, u64 reqid)
>         brcmf_dbg(TRACE, "reqid=%llu\n", reqid);
>
>         pi = ifp_to_pno(ifp);
> +
> +       /* No PNO reqeuset */

Typo. `reqeuset`

> +       if (!pi->n_reqs)
> +               return 0;
> +
>         err = brcmf_pno_remove_request(pi, reqid);
>         if (err)
>                 return err;
> --
> 2.1.0
>