Subject: Re: [PATCH 2/2] brcmfmac: support wake on ping packet
To:     Chi-Hsien Lin <Chi-Hsien.Lin@cypress.com>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc:     "brcm80211-dev-list@broadcom.com" <brcm80211-dev-list@broadcom.com>,
        brcm80211-dev-list <brcm80211-dev-list@cypress.com>,
        Franky Lin <franky.lin@broadcom.com>,
        Hante Meuleman <hante.meuleman@broadcom.com>,
        Wright Feng <Wright.Feng@cypress.com>,
        Kalle Valo <kvalo@codeaurora.org>,
        Double Lo <Double.Lo@cypress.com>
References: <1546501565-40752-1-git-send-email-chi-hsien.lin@cypress.com>
 <1546501565-40752-3-git-send-email-chi-hsien.lin@cypress.com>
From:   Arend Van Spriel <arend.vanspriel@broadcom.com>
Message-ID: <cad34d20-efd1-63c5-6981-cd87794259a4@broadcom.com>
Date:   Fri, 4 Jan 2019 13:17:28 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.3
MIME-Version: 1.0
In-Reply-To: <1546501565-40752-3-git-send-email-chi-hsien.lin@cypress.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 1/3/2019 8:46 AM, Chi-Hsien Lin wrote:
> From: Lo-Hsiang Lo <double.lo@cypress.com>
> 
> Set up wiphy->wowlan_config and a dummy wowlan filter so brcmfmac can
> remain connected during suspend. Enable an unicast packet filter during
> suspend so ping packets can wake up the system.

This basically enables a default wowlan configuration, but why do we 
want this in the driver. The struct wiphy::wowlan_config member is 
primarily managed by cfg80211 (see nl80211_set_wowlan()) upon user-space 
request.

If user-space reconfigures with no wowlan triggers the default 
configuration is freed, but as we have no .set_wakeup() callback the 
configuration in firmware remains unchanged so things are out of sync. 
So I would discourage this default approach and just let user-space deal 
with wowlan configuration.

Regards,
Arend