Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15D54C43387 for ; Fri, 18 Jan 2019 15:37:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D1ED52087E for ; Fri, 18 Jan 2019 15:37:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="ZhPxxCxQ"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="cey58c6Y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727630AbfARPhI (ORCPT ); Fri, 18 Jan 2019 10:37:08 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:46470 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727542AbfARPhH (ORCPT ); Fri, 18 Jan 2019 10:37:07 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 8A75460CF4; Fri, 18 Jan 2019 15:37:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1547825826; bh=07iEEVK7MWO8aF+2e4opG9oRji52g7VGu2bTiKecU0M=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ZhPxxCxQzBGzVzj040vwbIH59YQzmVR30p5U6T6xpHxLEazmXs8QpsHQb5mTd6ZNK ie7VyIAgt9qWpmbbB+M3gWFKA919LXM+Fa5e14aOChNAf2VX4riCc2iEDqfto2fr7x YxmPMa0WsadSdJYUz1aN4UPruWqbQYiM6V67JI00= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 25E026098B; Fri, 18 Jan 2019 15:37:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1547825823; bh=07iEEVK7MWO8aF+2e4opG9oRji52g7VGu2bTiKecU0M=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=cey58c6YfWPr4UhqASdEfsbdXgncqLCPwptW7Q7MnTRmdv5fXsPYqMX5EcqIk1VmR 2O9njhCCZtsiJLKxejAgaaWBe0EGH6zdFKAju0NudFhNTTbFdxyExNmSg/UfVXI6IX a7zV1mftRn3fNdYp1WDxbrNM+66dTykyT8XLVCu0= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 25E026098B Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Anders Roxell Cc: Tony Lindgren , Ulf Hansson , Eyal Reizer , linux-wireless@vger.kernel.org, Ricardo Salveti , Kishon Vijay Abraham I , John Stultz , Jan Kiszka , Linux Kernel Mailing List , linux-omap@vger.kernel.org Subject: Re: [PATCH V2] wlcore: sdio: Fixup power on/off sequence References: <20190116113723.15668-1-ulf.hansson@linaro.org> <20190116154311.GP5544@atomide.com> Date: Fri, 18 Jan 2019 17:36:58 +0200 In-Reply-To: (Anders Roxell's message of "Fri, 18 Jan 2019 16:05:25 +0100") Message-ID: <877ef2ou3p.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Anders Roxell writes: > On Wed, 16 Jan 2019 at 16:43, Tony Lindgren wrote: >> >> * Ulf Hansson [190116 11:37]: >> > During "wlan-up", we are programming the FW into the WiFi-chip. However, >> > re-programming the FW doesn't work, unless a power cycle of the WiFi-chip >> > is made in-between the programmings. >> > >> > To conform to this requirement and to fix the regression in a simple way, >> > let's start by allowing that the SDIO card (WiFi-chip) may stay powered on >> > (runtime resumed) when wl12xx_sdio_power_off() returns. The intent with the >> > current code is to treat this scenario as an error, but unfortunate this >> > doesn't work as expected, so let's fix this. >> > >> > The other part is to guarantee that a power cycle of the SDIO card has been >> > completed when wl12xx_sdio_power_on() returns, as to allow the FW >> > programming to succeed. However, relying solely on runtime PM to deal with >> > this isn't sufficient. For example, userspace may prevent runtime suspend >> > via sysfs for the device that represents the SDIO card, leading to that the >> > mmc core also keeps it powered on. For this reason, let's instead do a >> > brute force power cycle in wl12xx_sdio_power_on(). >> > >> > Fixes: 728a9dc61f13 ("wlcore: sdio: Fix flakey SDIO runtime PM handling") >> > Signed-off-by: Ulf Hansson >> > --- >> > >> > Changes in v2: >> > - Keep the SDIO host claimed when calling mmc_hw_reset(). >> > - Add a fixes tag. >> >> This v2 version works for me as tested with: >> >> # while [ 1 ]; do ifconfig wlan0 down; ifconfig wlan0 up; done >> [ 181.364990] wlcore: down >> [ 182.116424] wlcore: firmware booted (Rev 6.3.10.0.141) >> [ 182.151641] IPv6: ADDRCONF(NETDEV_UP): wlan0: link is not ready >> [ 182.166778] wlcore: down >> [ 182.773132] wlcore: firmware booted (Rev 6.3.10.0.141) >> [ 182.811096] IPv6: ADDRCONF(NETDEV_UP): wlan0: link is not ready >> ... >> >> Thanks for fixing this issue properly, and feel free to add: >> >> Tested-by: Tony Lindgren > > Tested-by: Anders Roxell > > I tested it on a hikey-6220, and it worked. So what's the conclusion, can I take this patch? I see that this didn't help with Jan but as Tony and Anders provided positive test results I'm inclined to take this now and Jan's problem can be fixed with another patch. Do everyone agree? -- Kalle Valo