Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59EF5C31681 for ; Mon, 21 Jan 2019 19:30:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 30C8420989 for ; Mon, 21 Jan 2019 19:30:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727752AbfAUTaq (ORCPT ); Mon, 21 Jan 2019 14:30:46 -0500 Received: from muru.com ([72.249.23.125]:34524 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727580AbfAUTaq (ORCPT ); Mon, 21 Jan 2019 14:30:46 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 9229480C0; Mon, 21 Jan 2019 19:30:52 +0000 (UTC) Date: Mon, 21 Jan 2019 11:30:42 -0800 From: Tony Lindgren To: Ulf Hansson Cc: Jan Kiszka , Kalle Valo , Eyal Reizer , linux-wireless@vger.kernel.org, Ricardo Salveti , Kishon Vijay Abraham I , Anders Roxell , John Stultz , Linux Kernel Mailing List , linux-omap Subject: Re: [PATCH V2] wlcore: sdio: Fixup power on/off sequence Message-ID: <20190121193042.GF5544@atomide.com> References: <20190116113723.15668-1-ulf.hansson@linaro.org> <258ecb6b-c2b2-c8b8-9804-4df69002d9f5@web.de> <5bf8514a-eb15-b098-1857-835b36d4a67c@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.1 (2018-12-01) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org * Ulf Hansson [190121 06:41]: > So, I have put together a debug patch, mostly to verify that things > seems to be correct in regards to runtime PM. It should produce some > prints to the log, particular during power on/off of the SDIO card and > during probe of the wifi driver. Please re-run the test on top of the > v2 version of the $subject patch. For reference, here's what I'm seeing on omap4 with your v2 fix and the debug patch for: # ifconfig wlan0 up; ifconfig wlan0 down Note that this is without pwrseq, so maybe that's the difference. Regards, Tony 8< ----------------- [ 148.458282] wl1271_sdio mmc4:0001:2: wl12xx_sdio_power_on: STEP1 [ 148.464691] mmc mmc4:0001: mmc_sdio_runtime_resume [ 148.641021] mmc mmc4:0001: mmc_sdio_runtime_resume - ret=0 DONE [ 148.647613] wl1271_sdio mmc4:0001:2: wl12xx_sdio_power_on: STEP2 [ 148.653961] wl1271_sdio mmc4:0001:2: wl12xx_sdio_power_on: STEP3 [ 148.660430] mmc mmc4:0001: mmc_sdio_hw_reset [ 148.828735] mmc mmc4:0001: mmc_sdio_hw_reset - ret=0 DONE [ 148.834503] wl1271_sdio mmc4:0001:2: wl12xx_sdio_power_on: STEP4 [ 148.840789] wl1271_sdio mmc4:0001:2: wl12xx_sdio_power_on: STEP5 [ 149.194671] wlcore: firmware booted (Rev 7.3.10.0.141) [ 149.200134] wl1271_sdio mmc4:0001:2: sdio_bus_runtime_resume [ 149.233276] IPv6: ADDRCONF(NETDEV_UP): wlan0: link is not ready [ 149.248352] wlcore: down [ 149.253082] wl1271_sdio mmc4:0001:2: wl12xx_sdio_power_off: STEP1 [ 149.259613] wl1271_sdio mmc4:0001:2: wl12xx_sdio_power_off: STEP2 [ 149.265869] wl1271_sdio mmc4:0001:2: wl12xx_sdio_power_off: STEP3 [ 149.272155] wl1271_sdio mmc4:0001:2: wl12xx_sdio_power_off: STEP4 [ 149.307952] wl1271_sdio mmc4:0001:2: sdio_bus_runtime_suspend [ 149.314147] mmc mmc4:0001: mmc_sdio_runtime_suspend [ 149.321136] mmc mmc4:0001: mmc_sdio_runtime_suspend - DONE