MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Tue, 22 Jan 2019 17:00:24 +0530
From:   vamsin@codeaurora.org
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     linux-wireless@vger.kernel.org, jouni@codeaurora.org
Subject: Re: [PATCH] nl80211/cfg80211: Add support to specify band specific
 min rssi thresholds with sched scan
In-Reply-To: <c5f276af0189d31d247c43e3ef79dad634568b37.camel@sipsolutions.net>
References: <1543566848-14819-1-git-send-email-vamsin@codeaurora.org>
 <49850508355f57fba6f9803416bf71c24766747b.camel@sipsolutions.net>
 <a6b9ae694194e5b766b0045fe1e4fc76@codeaurora.org>
 <c5f276af0189d31d247c43e3ef79dad634568b37.camel@sipsolutions.net>
Message-ID: <86e677e70f890b0e9bd85973228753e9@codeaurora.org>
User-Agent: Roundcube Webmail/1.2.5
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 2019-01-15 18:55, Johannes Berg wrote:

> 
>> > It seems that this should be with the existing
>> > NL80211_SCHED_SCAN_MATCH_ATTR_RSSI, not in this level namespace.
>> 
>> The band specific rssi thresholds that are being configured are global
>> across all matchsets whereas NL80211_SCHED_SCAN_MATCH_ATTR_* 
>> attributes
>> are mostly specific to each matchset. Hence I choose to define
>> attributes in higher level namespace. In future, whenever we want to
>> adding support for rssi thresholds per band and per matchset, we can
>> define attributes within NL80211_SCHED_SCAN_MATCH_ATTR_* namespace
>> level.
> 
> But why do we want global ones now?
> 

The global thresholds were there earlier as well. Earlier, we were using 
a matchset with only rssi attribute without any ssid/bssid attribute 
within the matchset. I thought having global attributes for specifying 
global thresholds is better way going forward and avoids unnecessary 
confusion. Mostly, same thresholds will be used for all ssids/bssids in 
general rather than thresholds specific to ssid/bssid. However, I 
couldn't see any disadvantage of using global attributes for this case, 
please let me know if you see any disadvantage/concern with this.

Thanks,
Vamsi