MIME-Version: 1.0
References: <20190122153823.46270-1-nbd@nbd.name>
In-Reply-To: <20190122153823.46270-1-nbd@nbd.name>
From:   Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>
Date:   Wed, 23 Jan 2019 13:10:59 +0100
Message-ID: <CAA2SeN+MJhwYq+c=R9cLZJqXGa_amvjpWF-bDHoLp1GXfzGVfA@mail.gmail.com>
Subject: Re: [PATCH 1/2] mt76: fix per-chain signal strength reporting
To:     Felix Fietkau <nbd@nbd.name>
Cc:     linux-wireless <linux-wireless@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

>
> Fix an off-by-one error that resulted in not reporting the signal strength
> for the first chain
>
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
> ---
>  drivers/net/wireless/mediatek/mt76/mt76x02_mac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt76x02_mac.c b/drivers/net/wireless/mediatek/mt76/mt76x02_mac.c
> index ce9bb702045f..63fa27d2c404 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt76x02_mac.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt76x02_mac.c
> @@ -648,7 +648,7 @@ int mt76x02_mac_process_rx(struct mt76x02_dev *dev, struct sk_buff *skb,
>
>         status->chains = BIT(0);
>         signal = mt76x02_mac_get_rssi(dev, rxwi->rssi[0], 0);

Here I guess we can do:

 signal = status->chain_signal[0] = mt76x02_mac_get_rssi(dev, rxwi->rssi[0], 0);

and avoid duplicated operations.

Regards,
Lorenzo

> -       for (i = 1; i < nstreams; i++) {
> +       for (i = 0; i < nstreams; i++) {
>                 status->chains |= BIT(i);
>                 status->chain_signal[i] = mt76x02_mac_get_rssi(dev,
>                                                                rxwi->rssi[i],
> --
> 2.17.0
>


-- 
UNIX is Sexy: who | grep -i blonde | talk; cd ~; wine; talk; touch;
unzip; touch; strip; gasp; finger; gasp; mount; fsck; more; yes; gasp;
umount; make clean; sleep