Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3392C282C0 for ; Fri, 25 Jan 2019 19:30:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 95991218F0 for ; Fri, 25 Jan 2019 19:30:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729327AbfAYTaY (ORCPT ); Fri, 25 Jan 2019 14:30:24 -0500 Received: from mga11.intel.com ([192.55.52.93]:61695 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726344AbfAYTaY (ORCPT ); Fri, 25 Jan 2019 14:30:24 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jan 2019 11:30:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,522,1539673200"; d="scan'208";a="119508806" Received: from mdochtor-mobl2.ger.corp.intel.com ([10.252.12.195]) by fmsmga008.fm.intel.com with ESMTP; 25 Jan 2019 11:30:22 -0800 Message-ID: <672e8d914d7e1ab23bf8a9988b571d6097707ede.camel@intel.com> Subject: Re: [PATCH] iwlwifi: fw: no need to check return value of debugfs_create functions From: Luciano Coelho To: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Cc: Johannes Berg , Emmanuel Grumbach , Intel Linux Wireless , Kalle Valo , linux-wireless@vger.kernel.org Date: Fri, 25 Jan 2019 21:30:20 +0200 In-Reply-To: <20190122152151.16139-22-gregkh@linuxfoundation.org> References: <20190122152151.16139-22-gregkh@linuxfoundation.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, 2019-01-22 at 16:21 +0100, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic > should > never do something different based on this. > > Cc: Johannes Berg > Cc: Emmanuel Grumbach > Cc: Luca Coelho > Cc: Intel Linux Wireless > Cc: Kalle Valo > Cc: linux-wireless@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman > --- Thanks, Greg! I applied this in our internal tree and it will reach upstream following our normal upstreaming process. -- Cheers, Luca.