MIME-Version: 1.0
References: <1548654407-28469-1-git-send-email-yhchuang@realtek.com>
 <043aedf4-0ed4-e128-3cd2-242aaef128f6@lwfinger.net> <F7CD281DE3E379468C6D07993EA72F84D1794AAB@RTITMBSVM04.realtek.com.tw>
In-Reply-To: <F7CD281DE3E379468C6D07993EA72F84D1794AAB@RTITMBSVM04.realtek.com.tw>
From:   Brian Norris <briannorris@chromium.org>
Date:   Mon, 28 Jan 2019 18:41:06 -0800
Message-ID: <CA+ASDXM=+_U+SrXhm3pq4Zd7gkvHwkRAZw+OGmzg=6+0+=iZGg@mail.gmail.com>
Subject: Re: [PATCH v3 00/13] rtw88: mac80211 driver for Realtek 802.11ac
 wireless network chips
To:     Tony Chuang <yhchuang@realtek.com>
Cc:     Larry Finger <Larry.Finger@lwfinger.net>,
        Pkshih <pkshih@realtek.com>, Andy Huang <tehuang@realtek.com>,
        "sgruszka@redhat.com" <sgruszka@redhat.com>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Mon, Jan 28, 2019 at 6:15 PM Tony Chuang <yhchuang@realtek.com> wrote:
> This NULL pointer was found months ago and has been fixed already.
> Thanks for your test :).
> I am holding the patch to fix it for the next patchsets.
>
> BTW, since rtw88 has not been accepted, could I send next patch set based on
> this patch set as long as I explicitly mark that the next patch is based on the previous one?

I'd normally expect that if you find major bugs in your initial driver
submission that still isn't reviewed/merged, you might as well just
roll the fix into latest version and describe it in the
cover-letter/changelog. This particular change is so trivial it
doesn't really seem to deserve a separate patch.

(It would also help people like me, who may very well run into the
same bug when they get around to testing/reviewing the driver.)

I also don't know what the contents of the "next patch set" is -- if
it's a lot of new features, maybe they don't deserve to clutter the
initial submission, but if they're bugfixes like this, it seems like
you could just fix the original patch set.

But that's just my opinion.

Brian