DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 5E2076047C
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Felix Fietkau <nbd@nbd.name>
Cc:     linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3/3] mt76: add driver for MT7603E and MT7628/7688
References: <20190130140756.91317-1-nbd@nbd.name>
        <20190130140756.91317-3-nbd@nbd.name>
Date:   Thu, 31 Jan 2019 13:20:42 +0200
In-Reply-To: <20190130140756.91317-3-nbd@nbd.name> (Felix Fietkau's message of
        "Wed, 30 Jan 2019 15:07:56 +0100")
Message-ID: <87pnsdrs39.fsf@purkki.adurom.net>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Felix Fietkau <nbd@nbd.name> writes:

> This driver is for a newer generation of 2x2 MediaTek 802.11n chipsets.
> MT7603E is a PCIe chip.
> MT7628 and MT7688 are MIPS SoC devices with built-in WLAN.
> MT7688 is limited to 1x1
>
> This driver fully supports AP, station, mesh, ad-hoc and monitor mode.
>
> Signed-off-by: Felix Fietkau <nbd@nbd.name>

[...]

> --- /dev/null
> +++ b/drivers/net/wireless/mediatek/mt76/mt7603/beacon.c
> @@ -0,0 +1,201 @@
> +/* SPDX-License-Identifier: ISC */
> +/*
> + * Copyright (C) 2016 Felix Fietkau <nbd@nbd.name>
> + *
> + * Permission to use, copy, modify, and/or distribute this software for any
> + * purpose with or without fee is hereby granted, provided that the above
> + * copyright notice and this permission notice appear in all copies.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
> + * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
> + * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
> + * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
> + * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
> + * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
> + * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
> + */

If you have the SPDX tag I don't think you need to have the license text
anymore. My understanding is that the SPDX identifier and copyright is
enough.

This comment is for all files in this patch.

-- 
Kalle Valo