From:   Francesco Napoleoni <fnapoleoni@mclink.it>
To:     linux-wireless@vger.kernel.org
Subject: Compilation error in rtl8821ce driver and possible fix
Date:   Sat, 02 Feb 2019 02:02:46 +0100
Message-ID: <4491429.ZAENLmHWg6@afrodite.mst.cosmic-odyssey.net>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="nextPart2183160.Dm167zZcW2"
Content-Transfer-Encoding: 7Bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

This is a multi-part message in MIME format.

--nextPart2183160.Dm167zZcW2
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"

Hi

A few days ago I downloaded rtl8821ce wireless network driver from endlessm/
linux repository (master branch), and I managed to build module for kernel=
=20
4.19.16 on my Linux laptop, a HP 15-DB0035NL with an AMD Ryzen 5 2500U CPU.

When upgrading to kernel 4.20.5 I could not build the module anymore, the=20
compilation stopped with an error about the use of get_monotonic_boottime()=
=20
function, which apparently was deprecated and has been removed.

I=E2=80=99m no expert in kernel development, however I discovered that such=
 function=20
has been superseded by ktime_get_boottime_ts64(), and so I tried to use it =
in=20
place of get_monotonic_boottime(). The resulting code compiled correctly, a=
nd=20
the module seems to load and work without problem.

The code I changed is in the rtl8821ce/os_dep/linux/ioctl_cfg80211.c (lines=
=20
338-339), you can find a patchfile attached here.

Sorry for any mistake I may have done in this report, this is the first tim=
e I=20
do such a thing.

greetings
=46rancesco Napoleoni

--nextPart2183160.Dm167zZcW2
Content-Disposition: attachment; filename="ioctl_cfg80211.c.patch"
Content-Transfer-Encoding: 7Bit
Content-Type: text/x-patch; charset="UTF-8"; name="ioctl_cfg80211.c.patch"

--- ioctl_cfg80211.c.old	2019-02-02 01:15:41.407123709 +0100
+++ ioctl_cfg80211.c	2019-02-02 01:16:18.459536625 +0100
@@ -335,8 +335,8 @@
 static u64 rtw_get_systime_us(void)
 {
 #if (LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 39))
-	struct timespec ts;
-	get_monotonic_boottime(&ts);
+	struct timespec64 ts;
+	ktime_get_boottime_ts64(&ts);
 	return ((u64)ts.tv_sec * 1000000) + ts.tv_nsec / 1000;
 #else
 	struct timeval tv;

--nextPart2183160.Dm167zZcW2--