Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7295C282C4 for ; Mon, 4 Feb 2019 08:14:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 862BE214DA for ; Mon, 4 Feb 2019 08:14:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="LXsRkZNL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728216AbfBDIOU (ORCPT ); Mon, 4 Feb 2019 03:14:20 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:33460 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728130AbfBDIOT (ORCPT ); Mon, 4 Feb 2019 03:14:19 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x148E1hG122704; Mon, 4 Feb 2019 08:14:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=SNcKTHm1QiL3IhHHDUmpQSCLC3/LJnywDBIcXiBdKGU=; b=LXsRkZNLUuuepNh/bdhORgSs9t9TfUAzZcLmdpqSmq+QBIkY0cB/fxwt3tzPipeiHGos G3LZmJPLBpFcqP7Jkoi+TZ5RaYllL93g7l267q/y3IQGHJ7A7dqxaH27OItaYTtCkF3F rNYKrvdxYW+C82drTMTLyMbBCRV7rCJnTxt2zQwjaQIk+wRjimV2oE7AJfqgtcGUlcJl pdRvgSR+PnvZ/KhWDx4Fi79OYkrsleRfOgwk/rh7ozsIBeo6lMZpfK1YqQYxBxg42Ivf 6ff5/hnouT9rEvQyEiaj3eH3dT4efuWmSFcxaNNZNMMRZwWWL20n0rn292zMpTlWkIZC hA== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2120.oracle.com with ESMTP id 2qd98munmg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 04 Feb 2019 08:14:12 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x148E7U6031430 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 4 Feb 2019 08:14:07 GMT Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x148E6Ea023344; Mon, 4 Feb 2019 08:14:06 GMT Received: from kadam (/197.157.0.18) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 04 Feb 2019 08:14:05 +0000 Date: Mon, 4 Feb 2019 11:13:57 +0300 From: Dan Carpenter To: Ajay.Kathat@microchip.com Cc: linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, johannes@sipsolutions.net, Adham.Abozaeid@microchip.com Subject: Re: [PATCH 08/15] staging: wilc1000: use correct condition in loops for 'vif_num' count Message-ID: <20190204081357.GC2563@kadam> References: <1549134974-5545-1-git-send-email-ajay.kathat@microchip.com> <1549134974-5545-9-git-send-email-ajay.kathat@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1549134974-5545-9-git-send-email-ajay.kathat@microchip.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9156 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=656 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902040068 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Sat, Feb 02, 2019 at 07:17:13PM +0000, Ajay.Kathat@microchip.com wrote: > From: Ajay Singh > > The value of 'vif_num'(interface count) starts with 0, so modified the > loop conditions to execute for all interface. > > Signed-off-by: Ajay Singh The right thing to do is to change ->vif_num = i + 1 in wilc_netdev_init(). That's how it was originally. Please, add a Fixes tag. Fixes: 735bb39ca3be ("staging: wilc1000: simplify vif[i]->ndev accesses") regards, dan carpenter