Subject: Re: [PATCH v2] arm64: dts: hikey: Give wifi some time after power-on
To:     Ulf Hansson <ulf.hansson@linaro.org>
CC:     Jan Kiszka <jan.kiszka@web.de>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        Ryan Grachek <ryan@edited.us>,
        "John Stultz" <john.stultz@linaro.org>,
        <linux-wireless@vger.kernel.org>, "Reizer, Eyal" <eyalr@ti.com>,
        Valentin Schneider <valentin.schneider@arm.com>,
        "Kalle Valo" <kvalo@codeaurora.org>,
        Tony Lindgren <tony@atomide.com>,
        "stable #4 . 17+" <stable@vger.kernel.org>
References: <e944650d-514f-3727-2e68-b318aab9ee7f@web.de>
 <14a011aa-862f-7132-8741-df5173875f34@hisilicon.com>
 <CAPDyKFqYWGv7bWW7rcCYhc-PdmRCBdskUTycFxK25VQgd0TWeg@mail.gmail.com>
From:   Wei Xu <xuwei5@hisilicon.com>
Message-ID: <6f4f342e-0b14-9344-c11b-e81f643cc45b@hisilicon.com>
Date:   Mon, 4 Feb 2019 11:13:59 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <CAPDyKFqYWGv7bWW7rcCYhc-PdmRCBdskUTycFxK25VQgd0TWeg@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Hi Ulf,

On 2/4/2019 6:06 AM, Ulf Hansson wrote:
> On Fri, 1 Feb 2019 at 17:34, Wei Xu <xuwei5@hisilicon.com> wrote:
>>
>> Hi Jan,
>>
>> On 1/24/2019 7:52 AM, Jan Kiszka wrote:
>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>>
>>> Somewhere along recent changes to power control of the wl1835, power-on
>>> became very unreliable on the hikey, failing like this:
>>>
>>> wl1271_sdio: probe of mmc2:0001:1 failed with error -16
>>> wl1271_sdio: probe of mmc2:0001:2 failed with error -16
>>>
>>> After playing with some dt parameters and comparing to other users of
>>> this chip, it turned out we need some power-on delay to make things
>>> stable again. In contrast to those other users which define 200 ms, the
>>> hikey would already be happy with 1 ms. Still, we use the safer 10 ms,
>>> like on the Ultra96.
>>>
>>> Fixes: ea452678734e ("arm64: dts: hikey: Fix WiFi support")
>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>> Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
>>
>> Applied to the hisilicon soc dt tree.
> 
> Wei, can you please also add a stable tag to it?

Yes, added below tag into this patch.
	Cc: <stable@vger.kernel.org> #4.12+

Thanks for your kindly reminder :)

Best Regards,
Wei

> 
> [...]
> 
> Thanks and kind regards
> Uffe
> 
> .
>