Date:   Mon, 4 Feb 2019 12:39:38 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Ajay.Kathat@microchip.com, devel@driverdev.osuosl.org,
        johannes@sipsolutions.net, linux-wireless@vger.kernel.org,
        Adham.Abozaeid@microchip.com
Cc:     Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH 08/15] staging: wilc1000: use correct condition in loops
 for 'vif_num' count
Message-ID: <20190204113938.GA24343@kroah.com>
References: <1549134974-5545-1-git-send-email-ajay.kathat@microchip.com>
 <1549134974-5545-9-git-send-email-ajay.kathat@microchip.com>
 <20190204081357.GC2563@kadam>
 <fdcab6a0-cf91-dc85-d674-ce4a3c9bd54d@microchip.com>
 <20190204094723.GD2581@kadam>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190204094723.GD2581@kadam>
User-Agent: Mutt/1.11.3 (2019-02-01)
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Mon, Feb 04, 2019 at 12:47:23PM +0300, Dan Carpenter wrote:
> On Mon, Feb 04, 2019 at 09:42:36AM +0000, Ajay.Kathat@microchip.com wrote:
> > 
> > 
> > On 2/4/2019 1:43 PM, Dan Carpenter wrote:
> > > On Sat, Feb 02, 2019 at 07:17:13PM +0000, Ajay.Kathat@microchip.com wrote:
> > >> From: Ajay Singh <ajay.kathat@microchip.com>
> > >>
> > >> The value of 'vif_num'(interface count) starts with 0, so modified the
> > >> loop conditions to execute for all interface.
> > >>
> > >> Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
> > > 
> > > The right thing to do is to change ->vif_num = i + 1 in
> > > wilc_netdev_init().  That's how it was originally.  Please, add a
> > > Fixes tag.
> > > 
> > > Fixes: 735bb39ca3be ("staging: wilc1000: simplify vif[i]->ndev accesses")
> > > 
> > 
> > Thanks. Sure, I will add Fixes tag and resubmit the changes.
> > 
> > Can other patches from the series be applied excluding this or should I
> > resubmit the complete series?
> > Please suggest.
> 
> I don't have an opinion on that.  I guess if you just resend them all,
> that's the easiest for Greg.

I took the first 7 patches here, so just a respin of the remaining ones
would be fine.

thanks,

greg k-h