Date:   Wed, 6 Feb 2019 15:59:59 +0100
From:   Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To:     Felix Fietkau <nbd@nbd.name>
Cc:     linux-wireless@vger.kernel.org, sgruszka@redhat.com
Subject: Re: [PATCH] mt76: move mt76_tx_queue_mcu in mt76-core module
Message-ID: <20190206145958.GA15380@localhost.localdomain>
References: <cover.1549444343.git.lorenzo.bianconi@redhat.com>
 <1d76867dab000720e648c68b4e1b90e81564f366.1549444343.git.lorenzo.bianconi@redhat.com>
 <5a00fd0c-3177-e057-de1a-d49c6a3b1af0@nbd.name>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5a00fd0c-3177-e057-de1a-d49c6a3b1af0@nbd.name>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

> On 2019-02-06 10:15, Lorenzo Bianconi wrote:
> > Move mt76_tx_queue_mcu routine in dma.c and remove duplicated code.
> > mt76_tx_queue_mcu will be reused adding support for mt7603 driver
> > 
> > Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
> I think we should rename this function, since it's going to be used for
> more than just MCU commands.
> Maybe mt76_dma_tx_queue_skb_raw (and add corresponding queue_op instead
> of direct calls)?
> While you're at it, maybe you could also remove mt76_queue_add_buf and
> the corresponding queue op.

ack, will fix it in v2

Regards,
Lorenzo

> 
> - Felix