Date:   Thu, 7 Feb 2019 13:02:25 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Ajay.Kathat@microchip.com
Cc:     devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
        linux-wireless@vger.kernel.org, stable@vger.kernel.org,
        Adham.Abozaeid@microchip.com, johannes@sipsolutions.net
Subject: Re: [PATCH 1/9] staging: wilc1000: revert fix related to vif index
Message-ID: <20190207100225.GE1978@kadam>
References: <1549519927-2651-1-git-send-email-ajay.kathat@microchip.com>
 <1549519927-2651-2-git-send-email-ajay.kathat@microchip.com>
 <20190207081242.GC1978@kadam>
 <8952ae4a-52a9-354b-2368-76419d15e6af@microchip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8952ae4a-52a9-354b-2368-76419d15e6af@microchip.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Thu, Feb 07, 2019 at 09:39:54AM +0000, Ajay.Kathat@microchip.com wrote:
> Hi Dan,
> 
> On 2/7/2019 1:42 PM, Dan Carpenter wrote:
> > This patch was very confusing to review...
> 
> Apologies for the confusion.
> 
> > From a process perspective, you really should fold patches 1 and 2
> > together.  Otherwise we're re-introducing a bug.
> 
> Patch 1 and Patch 2 both are required if commit 0e490657c721 ("staging:
> wilc1000: Fix problem with wrong vif index") is applied else Patch 2 is
> enough for complete fix. For the above reason, I have divided the fixes
> into 2 patches.
> Please suggest, if I should go ahead and submit this in a single patch.
> Should I put 2 'Fixes:' tag in that merge commit or only 0e490657c721
> commit is enough.
> 

I always just go with the oldest one.  Another option is to include
both.

regards,
dan carpenter