DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 29CAE601D7
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Larry Finger <Larry.Finger@lwfinger.net>
Cc:     linux-wireless@vger.kernel.org, pkshih@realtek.com
Subject: Re: [PATCH 01/13] rtlwifi: Replace old-style license information
References: <20190208172209.28530-1-Larry.Finger@lwfinger.net>
        <20190208172209.28530-2-Larry.Finger@lwfinger.net>
Date:   Sat, 09 Feb 2019 08:02:37 +0200
In-Reply-To: <20190208172209.28530-2-Larry.Finger@lwfinger.net> (Larry
        Finger's message of "Fri, 8 Feb 2019 11:21:57 -0600")
Message-ID: <87tvhd33eq.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Larry Finger <Larry.Finger@lwfinger.net> writes:

> The traditional license information is replaced by the SPDX form. There
> are no code changes.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>

[...]

> --- a/drivers/net/wireless/realtek/rtlwifi/base.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/base.c
> @@ -1,27 +1,5 @@
> -/******************************************************************************
> - *
> - * Copyright(c) 2009-2012  Realtek Corporation.
> - *
> - * This program is free software; you can redistribute it and/or modify it
> - * under the terms of version 2 of the GNU General Public License as
> - * published by the Free Software Foundation.

So the way I see this is GPLv2 only (so GPLv3 is not included).

> +/* SPDX-License-Identifier: GPL-2.0+ */

But this is GPLv2 or later (including GPLv3 for example).
LICENSES/preferred/GPL-2.0 contains more info about the tags.

Also for SPDX tags in .c files you should use C++ comment style '//',
BUT in .h files normal C comment style '/* */'. Confusing, I know :/

https://www.kernel.org/doc/html/latest/process/license-rules.html#license-identifier-syntax

-- 
Kalle Valo