Authenticated-By: 
From:   Tony Chuang <yhchuang@realtek.com>
To:     Brian Norris <briannorris@chromium.org>
CC:     "kvalo@codeaurora.org" <kvalo@codeaurora.org>,
        "Larry.Finger@lwfinger.net" <Larry.Finger@lwfinger.net>,
        Andy Huang <tehuang@realtek.com>,
        "sgruszka@redhat.com" <sgruszka@redhat.com>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH 00/24] rtw88: major fixes for 8822c to have stable functionalities
Thread-Topic: [PATCH 00/24] rtw88: major fixes for 8822c to have stable
 functionalities
Thread-Index: AQHUuV+TtXNINyxKz06KyTixZeqEA6XJtjKAgBA6eWA=
Date:   Mon, 11 Feb 2019 02:30:57 +0000
Message-ID: <F7CD281DE3E379468C6D07993EA72F84D17A2858@RTITMBSVM04.realtek.com.tw>
References: <1548937297-14660-1-git-send-email-yhchuang@realtek.com>
 <20190201024042.GB125494@google.com>
In-Reply-To: <20190201024042.GB125494@google.com>
Accept-Language: zh-TW, en-US
Content-Language: zh-TW
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk


> From: Brian Norris [mailto:briannorris@chromium.org]
> Subject: Re: [PATCH 00/24] rtw88: major fixes for 8822c to have stable
> functionalities
> 
> On Thu, Jan 31, 2019 at 08:21:13PM +0800, yhchuang@realtek.com wrote:
> > From: Yan-Hsuan Chuang <yhchuang@realtek.com>
> >
> > Note this patch set is based on the original patch set "rtw88: mac80211
> > driver for Realtek 802.11ac wireless network chips".
> 
> The latest would be here, for reference:
> 
> https://patchwork.kernel.org/cover/10787651/
> http://lkml.kernel.org/linux-wireless/1548820940-15237-1-git-send-email-yhch
> uang@realtek.com
> 
> > These patches are mean to make sure 8822c chip to operate normal for most
> > of the basic functionalities, such as power on, switch channel, scan,
> > connection establish and connection monitor.
> >
> > As the original patch set was sent 3 months ago, progress has been made
> > by Realtek during the past months. Now we have tested on more chips and
> > released tables and parameters for them. Also the chips are all
> > programed with efuse map released for 8822c.
> >
> > Most of the changes are about BB and RF, both control the tx/rx path.
> > PHY parameters/seq and efuse info make sure the hardware is powered on
> > correctly. And channel setting updates help driver to switch to target
> > channel accurately. Then trx mode setting and DACK will make hardware to
> > have stable performance to tx/rx to connect to AP.
> >
> > Here tx power control is also required to transmit with a precise power.
> > Otherwise if the power is too high or too low, the peer might not be able
> > to receive the signal.
> >
> > Finally, we need to report correct tx status for mac80211's connection
> > monitor system, this requires firmware's C2H of tx status report. After
> > this, users can use 8822c chips for more stable wireless communication.
> 
> Besides the comments I added (and needing to fix the out-of-bounds
> reads), this series helpfully adds RFE 1 support, so the 8822C chip I
> have works for some basic functions -- it's not too snappy, and I feel
> like there's still plenty of room for improvement but:
> 
> Tested-by: Brian Norris <briannorris@chromium.org>
> 
> And except for a handful of patches (should look at patch 1 closer),
> these all look pretty sane and helpful.
> 
> Reviewed-by: Brian Norris <briannorris@chromium.org>
> 
> I still need to pass back over the original patchset and try a few more
> things out.
> 
> Regards,
> Brian

Thanks for your review, helps a lot!

Yan-Hsuan