Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 183F9C282CC for ; Mon, 11 Feb 2019 08:38:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DB08120863 for ; Mon, 11 Feb 2019 08:38:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="n+dLEfQl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727137AbfBKIih (ORCPT ); Mon, 11 Feb 2019 03:38:37 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:46741 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727090AbfBKIih (ORCPT ); Mon, 11 Feb 2019 03:38:37 -0500 Received: by mail-lj1-f193.google.com with SMTP id x25-v6so4365122ljj.13 for ; Mon, 11 Feb 2019 00:38:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=sb8NaGm2k/XwWwVVppweFWt8LA6VpiYcLXVpJw5XySQ=; b=n+dLEfQliRHulGENEzjiPtUKTF95uOEQRIZxdgLtLbSute1MpTPKXHmCZKPYS4qqOA 0JTJ50wGKXwJcyvr1eqiNb1Nk1U4k9uhLLE/wWx5ka1A+z1kAReKU4RpJogimUwe8sFu mbCjYrXBDH722WdOw5bH2HBemQyYTssoVdChqEoBw4INCjmr0rHGP1MEW4F8KDOBHowG 3ewz/IkFwz6SoHpV0DntU33sIvvRmK5QpGO/DMBdNjrKDs/fGOmfEJQg9msPkuAFcRYT ZYJoeeOAai/MoHBg+41quwhHYJV+e8vzayEeYZBG+eWqremf8lSSGX4eC7nF+rxOwt6Y s8zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=sb8NaGm2k/XwWwVVppweFWt8LA6VpiYcLXVpJw5XySQ=; b=jmZug+uDW1hvAvtnaVUtdOgaC0EW8sO9Wxnl3kwCSQGYVQLRUIiA+ZK/J5KyDH1eVy 2r4ymfK8+hScr7J529j6UkVKeddGZebOdOiksr0YvVLW+jq0qnxHg533f7S3FEQKJ5r+ ZB9QsKtPDfQzIDMADE5YaJE28PV1pchhkBazONOCoiIPPxgu/8o0fc2EOhUIQjqLhDur E4tDc+0kSSQJUNkCDDgip4e1n+PGOSPMeOu5jHaKiiHNtlqOj7+APv3CME1+zsL/suN5 bd9q8GCfcDO4JjWbag3ABOy3N4BsHXP9dUNq+chLKsSNOxY88ZoliVk2EfECG7o/wLcN MZrg== X-Gm-Message-State: AHQUAuZHrRgzpXCvqwPfQKoSj3NH9FBkqmrT4vl9D2S8F3bEJE2i5/vj GQTXEyTfNV4Uw05Gf6rAixE3XQ== X-Google-Smtp-Source: AHgI3IalEdsHrVsZ51LARQNXZQ3spxRW/+BJSSq0JtR6ias3E4teg7bp4KSsBkjIRY67D/TlcAq7vQ== X-Received: by 2002:a2e:8ece:: with SMTP id e14-v6mr1768934ljl.64.1549874315029; Mon, 11 Feb 2019 00:38:35 -0800 (PST) Received: from [192.168.0.199] ([31.173.84.177]) by smtp.gmail.com with ESMTPSA id l27sm1519023lfk.6.2019.02.11.00.38.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Feb 2019 00:38:34 -0800 (PST) Subject: Re: [PATCH] mt76: change the retun type of mt76_dma_attach() To: Ryder Lee , Lorenzo Bianconi , Felix Fietkau , Kalle Valo Cc: Roy Luo , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-mediatek@lists.infradead.org References: <228fdddb9ca96e8ce861e324eb9039722cf18f49.1549850911.git.ryder.lee@mediatek.com> From: Sergei Shtylyov Message-ID: Date: Mon, 11 Feb 2019 11:38:28 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <228fdddb9ca96e8ce861e324eb9039722cf18f49.1549850911.git.ryder.lee@mediatek.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Hello! On 11.02.2019 5:13, Ryder Lee wrote: > There is no need to retun 0 in mt76_dma_attach(), so switch it to void. ^ r missing :-) > > Signed-off-by: Ryder Lee [...] MBR, Sergei