MIME-Version: 1.0
References: <20190210194749.18135-1-lkundrak@v3.sk>
In-Reply-To: <20190210194749.18135-1-lkundrak@v3.sk>
From:   Steve deRosier <derosier@gmail.com>
Date:   Mon, 11 Feb 2019 05:38:10 -0800
Message-ID: <CALLGbR+MiHDfgFxu=RZcr2GhYcyG4Jaq5m8O3VHPiTQCLUKGEA@mail.gmail.com>
Subject: Re: [PATCH] libertas_tf: don't set URB_ZERO_PACKET on IN USB transfer
To:     Lubomir Rintel <lkundrak@v3.sk>
Cc:     Kalle Valo <kvalo@codeaurora.org>,
        "David S. Miller" <davem@davemloft.net>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, stable@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Sun, Feb 10, 2019 at 11:48 AM Lubomir Rintel <lkundrak@v3.sk> wrote:
>
> It doesn't make sense and the USB core warns on each submit of such
> URB, easily flooding the message buffer with tracebacks.
>
> Analogous issue was fixed in regular libertas driver in commit 6528d8804780
> ("libertas: don't set URB_ZERO_PACKET on IN USB transfer").
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> ---
>  drivers/net/wireless/marvell/libertas_tf/if_usb.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/wireless/marvell/libertas_tf/if_usb.c b/drivers/net/wireless/marvell/libertas_tf/if_usb.c
> index 789337ea676a..6ede6168bd85 100644
> --- a/drivers/net/wireless/marvell/libertas_tf/if_usb.c
> +++ b/drivers/net/wireless/marvell/libertas_tf/if_usb.c
> @@ -433,8 +433,6 @@ static int __if_usb_submit_rx_urb(struct if_usb_card *cardp,
>                           skb_tail_pointer(skb),
>                           MRVDRV_ETH_RX_PACKET_BUFFER_SIZE, callbackfn, cardp);
>
> -       cardp->rx_urb->transfer_flags |= URB_ZERO_PACKET;
> -
>         lbtf_deb_usb2(&cardp->udev->dev, "Pointer for rx_urb %p\n",
>                 cardp->rx_urb);
>         ret = usb_submit_urb(cardp->rx_urb, GFP_ATOMIC);
> --
> 2.20.1
>

Reviewed-by: Steve deRosier <derosier@cal-sierra.com>