Subject: Re: PROBLEM: Oops - Null pointer dereference in brcm80211/brcmfmac
 [BCM4350]
To:     Aaron Blair <aaron@aaronpb.me>,
        Franky Lin <franky.lin@broadcom.com>,
        Hante Meuleman <hante.meuleman@broadcom.com>,
        Chi-Hsien Lin <chi-hsien.lin@cypress.com>,
        Wright Feng <wright.feng@cypress.com>
Cc:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "brcm80211-dev-list.pdl@broadcom.com" 
        <brcm80211-dev-list.pdl@broadcom.com>,
        "brcm80211-dev-list@cypress.com" <brcm80211-dev-list@cypress.com>
References: <20190212055731.gxy3e3uulztketbf@datkip>
From:   Arend Van Spriel <arend.vanspriel@broadcom.com>
Message-ID: <43fcfb23-9c35-cdf4-18ea-69212612c460@broadcom.com>
Date:   Wed, 13 Feb 2019 14:01:46 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.0
MIME-Version: 1.0
In-Reply-To: <20190212055731.gxy3e3uulztketbf@datkip>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 2/12/2019 6:57 AM, Aaron Blair wrote:
> I apologise if my report is lacking in detail; it is my first attempt at 
> bug/issue reporting in the kernel.
> Please follow up if something is missing, or more detail/testing is 
> required.
> It is certainly possible for me to provide more oops reports if 
> required, as they generally surface at least once a day.

No apologies needed. I am generally happy with kernel log and short 
context description.

> Thank you.
> 
> [1.] Oops - Null pointer dereference in brcm80211/brcmfmac [BCM4350]
> 
> [2.] Seemingly randomly, when connected to a wireless network, my laptop 
> will begin failing to tx/rx data, and begin repeatedly reporting the 
> following messages in the kernel ring buffer:
> 
> ```
> [18990.872335] brcmfmac: brcmf_cfg80211_get_station: GET STA INFO 
> failed, -12
> [18990.872433] brcmfmac: brcmf_msgbuf_tx_ioctl: Failed to reserve space 
> in commonring
> [18990.872439] brcmfmac: brcmf_cfg80211_get_tx_power: error (-12)
> ```

The "reserve space" issue has been reported before although I have not 
looking into it yet.

> Upon trying to rmmod && modload brcmfmac, I receive the oops dump 
> included below, and am unable to continue using the wireless NIC until I 
> reboot.
> 
> This does not appear to have a pattern, except that it usually happens 
> at least once throughout a day of work.
> 
> It has been happening at least since 4.20.4, but potentially earlier 
> (this machine wasn't in heavy use before then).

I will look into the NULL pointer access.

Regards,
Arend