Subject: Re: [PATCH] brcmfmac: use bphy_err() in all wiphy-related code
To:     Dan Carpenter <dan.carpenter@oracle.com>,
        Kalle Valo <kvalo@codeaurora.org>, kbuild@01.org,
        kbuild-all@01.org
Cc:     =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>,
        linux-wireless@vger.kernel.org,
        brcm80211-dev-list.pdl@broadcom.com,
        brcm80211-dev-list@cypress.com,
        =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>
References: <20190215061601.GE2304@kadam>
 <87bm3dz7tc.fsf@kamboji.qca.qualcomm.com> <20190215103803.GF2304@kadam>
From:   Arend Van Spriel <arend.vanspriel@broadcom.com>
Message-ID: <87766c4c-f3ec-8f95-0210-0e1971092e61@broadcom.com>
Date:   Fri, 15 Feb 2019 11:40:07 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.0
MIME-Version: 1.0
In-Reply-To: <20190215103803.GF2304@kadam>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 2/15/2019 11:38 AM, Dan Carpenter wrote:
> On Fri, Feb 15, 2019 at 12:04:31PM +0200, Kalle Valo wrote:
>> Dan Carpenter <dan.carpenter@oracle.com> writes:
>>
>>> Hi Rafał,
>>>
>>> url:
>>> https://github.com/0day-ci/linux/commits/Rafa-Mi-ecki/brcmfmac-use-bphy_err-in-all-wiphy-related-code/20190214-140004
>>> base:
>>> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git
>>> master
>>>
>>> smatch warnings:
>>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c:114
>>> brcmf_fweh_call_event_handler() warn: variable dereferenced before
>>> check 'ifp' (see line 110)
>>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c:187
>>> brcmf_fweh_handle_if_event() error: we previously assumed 'ifp' could
>>> be null (see line 184)
>>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c:189
>>> brcmf_fweh_handle_if_event() warn: variable dereferenced before check
>>> 'ifp' (see line 187)
>>>
>>> # https://github.com/0day-ci/linux/commit/e12dba9f5ed77216c5984a4b57ddc31ba23376c9
>>> git remote add linux-review https://github.com/0day-ci/linux
>>> git remote update linux-review
>>> git checkout e12dba9f5ed77216c5984a4b57ddc31ba23376c9
>>> vim +/ifp +114 drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c
>>>
>>> 5c36b99a drivers/net/wireless/brcm80211/brcmfmac/fweh.c Arend van
>>> Spriel 2012-11-14 104
>>> 3e0a97e1 drivers/net/wireless/brcm80211/brcmfmac/fweh.c Arend van
>>> Spriel 2012-11-14 105 static int brcmf_fweh_call_event_handler(struct
>>> brcmf_if *ifp,
>>> 3e0a97e1 drivers/net/wireless/brcm80211/brcmfmac/fweh.c Arend van
>>> Spriel 2012-11-14 106 enum brcmf_fweh_event_code code,
>>> 3e0a97e1 drivers/net/wireless/brcm80211/brcmfmac/fweh.c Arend van
>>> Spriel 2012-11-14 107 struct brcmf_event_msg *emsg,
>>> 3e0a97e1 drivers/net/wireless/brcm80211/brcmfmac/fweh.c Arend van
>>> Spriel 2012-11-14 108 void *data)
>>> 3e0a97e1 drivers/net/wireless/brcm80211/brcmfmac/fweh.c Arend van
>>
>> This report is very hard to read as the lines seem to be wrapped.
>>
> 
> I feel like removing the filenames would make the reports more legible.
> We can get that information from the git hash if we really need it.
> 
> Maybe just put the filename at the start:
> 
> drivers/net/wireless/brcm80211/brcmfmac/fweh.c
> 5c36b99a Arend van Spriel 2012-11-14 104
> 3e0a97e1 Arend van Spriel 2012-11-14 105 static int brcmf_fweh_call_event_handler(struct brcmf_if *ifp,

Looks good to me.

Regards,
Arend