DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D804E6053D
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Larry Finger <Larry.Finger@lwfinger.net>
Cc:     linux-wireless@vger.kernel.org, pkshih@realtek.com
Subject: Re: [PATCH 0/8] rtlwifi: Remove CamelCase variables from all drivers
References: <20190214223644.8035-1-Larry.Finger@lwfinger.net>
Date:   Fri, 15 Feb 2019 12:54:04 +0200
In-Reply-To: <20190214223644.8035-1-Larry.Finger@lwfinger.net> (Larry Finger's
        message of "Thu, 14 Feb 2019 16:36:36 -0600")
Message-ID: <87wom1xqyb.fsf@kamboji.qca.qualcomm.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Larry Finger <Larry.Finger@lwfinger.net> writes:

> This set of patches fix all instances of CamelCase for all the drivers.
> When the symbol refers to a macro, it is converted to upper case. If a
> variable or a function, then it is converted to lower case.
>
> As noted in the comments, some of the other checkpatch exceptions are
> addressed.

I wish you had separated the camel case fixes from other cleanups, and
otherwise tried to simplify the patches, now you made the patchset
painful to review as all the changes are mixed and the size of patches
is just too large. Remember that the rule of thumb is one logical change
per patch. Of course that's not a hard rule, and can be ignored with
small and trivial patches, but most of the patches here are not small.

No need to resend because of this but please take care with the size of
patches and patchsets in the future.

-- 
Kalle Valo