Message-ID: <0519f25cf73d8a91202e40b08e94de8d2520411e.camel@sipsolutions.net>
Subject: Re: [RFC PATCH v3 04/12] mac80211: Compatibility Extended Key ID
 support
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Alexander Wetzel <alexander@wetzel-home.de>
Cc:     linux-wireless@vger.kernel.org
Date:   Fri, 15 Feb 2019 12:09:50 +0100
In-Reply-To: <20190210210620.31181-5-alexander@wetzel-home.de>
References: <20190210210620.31181-1-alexander@wetzel-home.de>
         <20190210210620.31181-5-alexander@wetzel-home.de>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk


> +	if (!ext_native && key->flags & KEY_FLAG_UPLOADED_TO_HARDWARE) {
> +		key->flags |= KEY_FLAG_RX_SW_CRYPTO;
> +		/* Activate Rx crypto offload after max 10s when idle */
> +		ieee80211_queue_delayed_work(&local->hw, &sta->ext_key_compat_wk,
> +					     round_jiffies_relative(HZ * 10));
> +	}

Is there much point in this?

> +		if (unlikely(rx->key->flags & KEY_FLAG_RX_SW_CRYPTO)) {
> +			rx->key->flags &= ~KEY_FLAG_RX_SW_CRYPTO;
> +			cancel_delayed_work(&rx->sta->ext_key_compat_wk);
> +			ieee80211_queue_delayed_work(&rx->local->hw,
> +						     &rx->sta->ext_key_compat_wk, 0);
> +		}

We'll almost certainly do it from here, so never exercise the other
path?

johannes