Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C88CC43381 for ; Mon, 18 Feb 2019 10:25:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 40A5021736 for ; Mon, 18 Feb 2019 10:25:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729296AbfBRKZS (ORCPT ); Mon, 18 Feb 2019 05:25:18 -0500 Received: from orcrist.hmeau.com ([104.223.48.154]:58876 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728909AbfBRKZS (ORCPT ); Mon, 18 Feb 2019 05:25:18 -0500 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1gvg6p-0005a8-2G; Mon, 18 Feb 2019 18:25:11 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1gvg6m-0005mB-Uh; Mon, 18 Feb 2019 18:25:08 +0800 Date: Mon, 18 Feb 2019 18:25:08 +0800 From: Herbert Xu To: Wei Yongjun Cc: Johannes Berg , linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] mac80211: mesh: fix missing unlock on error in table_path_del() Message-ID: <20190218102508.wiflqxvfyxqcss2y@gondor.apana.org.au> References: <20190218065216.155259-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190218065216.155259-1-weiyongjun1@huawei.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, Feb 18, 2019 at 06:52:16AM +0000, Wei Yongjun wrote: > spin_lock_bh() is used in table_path_del() but rcu_read_unlock() > is used for unlocking. Fix it by using spin_unlock_bh() instead > of rcu_read_unlock() in the error handling case. > > Fixes: b4c3fbe63601 ("mac80211: Use linked list instead of rhashtable walk for mesh tables") > Signed-off-by: Wei Yongjun Acked-by: Herbert Xu Thanks for catching this! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt