MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Wed, 20 Feb 2019 12:50:51 +0530
From:   dasaris@codeaurora.org
To:     Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
Cc:     johannes@sipsolutions.net, linux-wireless@vger.kernel.org,
        Sunil Dutt <usdutt@codeaurora.org>,
        Liangwei Dong <liangwei@codeaurora.org>
Subject: Re: [PATCH] cfg80211/nl80211: Offload OWE processing to user space in
 AP mode
In-Reply-To: <20190216041112.zl2kpec2xu5fykjw@bars>
References: <1550258078-13504-1-git-send-email-dasaris@codeaurora.org>
 <20190216041112.zl2kpec2xu5fykjw@bars>
Message-ID: <3b81948a5e2b3a27f2c55d7ea6ee827e@codeaurora.org>
User-Agent: Roundcube Webmail/1.2.5
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 2019-02-16 09:41, Sergey Matyukevich wrote:
> Hi Srinivas,
> 
>>  include/net/cfg80211.h       | 42 ++++++++++++++++++++++++++
>>  include/uapi/linux/nl80211.h |  7 +++++
>>  net/wireless/nl80211.c       | 72 
>> ++++++++++++++++++++++++++++++++++++++++++++
>>  net/wireless/rdev-ops.h      | 13 ++++++++
>>  net/wireless/trace.h         | 38 +++++++++++++++++++++++
>>  5 files changed, 172 insertions(+)
> 
> ...
> 
>> +void cfg80211_update_owe_info_event(struct net_device *netdev,
>> +                                   struct cfg80211_update_owe_info 
>> *owe_info,
>> +                                   gfp_t gfp)
>> +{
>> +       struct wiphy *wiphy = netdev->ieee80211_ptr->wiphy;
>> +       struct cfg80211_registered_device *rdev = 
>> wiphy_to_rdev(wiphy);
>> +       struct sk_buff *msg;
>> +       void *hdr;
>> +
>> +       trace_cfg80211_update_owe_info_event(wiphy, netdev, owe_info);
>> +
>> +       msg = nlmsg_new(NLMSG_DEFAULT_SIZE, gfp);
>> +       if (!msg)
>> +               return;
>> +
>> +       hdr = nl80211hdr_put(msg, 0, 0, 0, 
>> NL80211_CMD_UPDATE_OWE_INFO);
>> +       if (!hdr)
>> +               goto nla_put_failure;
>> +
>> +       if (nla_put_u32(msg, NL80211_ATTR_WIPHY, rdev->wiphy_idx) ||
>> +           nla_put_u32(msg, NL80211_ATTR_IFINDEX, netdev->ifindex) ||
>> +           nla_put(msg, NL80211_ATTR_MAC, ETH_ALEN, owe_info->peer))
>> +               goto nla_put_failure;
>> +
>> +       if (nla_put(msg, NL80211_ATTR_IE, owe_info->ie_len, 
>> owe_info->ie))
>> +               goto nla_put_failure;
> 
> Maybe worth adding sanity check if IE length is non-zero ?
> 
> 
> Reviewed-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
> 
> Regards,
> Sergey

Thanks for the review. owe_info->ie is a mandatory field to be provided 
to the userspace as part of this event. We shall add a sanity check on 
IE length and reject(drop) the request from driver if it is 0. We shall 
update new patchset.

Regards,
Srinivas