Subject: Re: [PATCH wireless-drivers-next 2/2] brcmfmac: print firmware
 reported general status errors
To:     =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>,
        Kalle Valo <kvalo@codeaurora.org>
Cc:     linux-wireless@vger.kernel.org,
        brcm80211-dev-list.pdl@broadcom.com,
        brcm80211-dev-list@cypress.com,
        =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>
References: <20190221103325.28228-1-zajec5@gmail.com>
 <20190221103325.28228-2-zajec5@gmail.com>
From:   Arend Van Spriel <arend.vanspriel@broadcom.com>
Message-ID: <e644a5b7-c70d-056a-740e-997c931863c2@broadcom.com>
Date:   Thu, 21 Feb 2019 11:45:20 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.0
MIME-Version: 1.0
In-Reply-To: <20190221103325.28228-2-zajec5@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk


On 2/21/2019 11:33 AM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> Firmware may report general errors using a special message type. Add
> basic support for it by simply decoding & printing an error number.
> 
> A sample situation in which firmware reports a buf error:
> CONSOLE: 027084.733 no host response IOCTL buffer available..so fail the request
> will now produce a "Firmware reported general error: 9" on the host.

Could have meaningful message instead of a number. I can do that in 
follow up patch if you do not have the information.

Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
>   .../broadcom/brcm80211/brcmfmac/msgbuf.c      | 24 +++++++++++++++++++
>   1 file changed, 24 insertions(+)
> 
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c
> index d711dc8ed606..d3780eae7f19 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c
> @@ -134,6 +134,14 @@ struct msgbuf_completion_hdr {
>   	__le16				flow_ring_id;
>   };
>   
> +/* Data struct for the MSGBUF_TYPE_GEN_STATUS */
> +struct msgbuf_gen_status {
> +	struct msgbuf_common_hdr	msg;
> +	struct msgbuf_completion_hdr	compl_hdr;
> +	__le16				write_idx;
> +	__le32				rsvd0[3];
> +};
> +
>   /* Data struct for the MSGBUF_TYPE_RING_STATUS */
>   struct msgbuf_ring_status {
>   	struct msgbuf_common_hdr	msg;
> @@ -1194,6 +1202,18 @@ brcmf_msgbuf_process_rx_complete(struct brcmf_msgbuf *msgbuf, void *buf)
>   	brcmf_netif_rx(ifp, skb);
>   }
>   
> +static void brcmf_msgbuf_process_gen_status(struct brcmf_msgbuf *msgbuf,
> +					    void *buf)
> +{
> +	struct msgbuf_gen_status *gen_status = buf;
> +	struct brcmf_pub *drvr = msgbuf->drvr;
> +	int err;
> +
> +	err = le16_to_cpu(gen_status->compl_hdr.status);
> +	if (err)
> +		bphy_err(drvr, "Firmware reported general error: %d\n", err);
> +}
> +
>   static void brcmf_msgbuf_process_ring_status(struct brcmf_msgbuf *msgbuf,
>   					     void *buf)
>   {
> @@ -1273,6 +1293,10 @@ static void brcmf_msgbuf_process_msgtype(struct brcmf_msgbuf *msgbuf, void *buf)
>   
>   	msg = (struct msgbuf_common_hdr *)buf;
>   	switch (msg->msgtype) {
> +	case MSGBUF_TYPE_GEN_STATUS:
> +		brcmf_dbg(MSGBUF, "MSGBUF_TYPE_GEN_STATUS\n");
> +		brcmf_msgbuf_process_gen_status(msgbuf, buf);
> +		break;
>   	case MSGBUF_TYPE_RING_STATUS:
>   		brcmf_dbg(MSGBUF, "MSGBUF_TYPE_RING_STATUS\n");
>   		brcmf_msgbuf_process_ring_status(msgbuf, buf);
>