Subject: Re: [RFC PATCH v3 00/12] Draft for Extended Key ID support
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     linux-wireless@vger.kernel.org
References: <20190210210620.31181-1-alexander@wetzel-home.de>
 <67c355e3b3078b55267c075d48b48bcb42435b11.camel@sipsolutions.net>
From:   Alexander Wetzel <alexander@wetzel-home.de>
Message-ID: <40ef7f07-987b-405b-f0c8-d4ec320fc928@wetzel-home.de>
Date:   Thu, 21 Feb 2019 21:44:06 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.0
MIME-Version: 1.0
In-Reply-To: <67c355e3b3078b55267c075d48b48bcb42435b11.camel@sipsolutions.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk


Am 15.02.19 um 12:10 schrieb Johannes Berg:
> On Sun, 2019-02-10 at 22:06 +0100, Alexander Wetzel wrote:
>>
>> The driver patches are - with the exception of the hwsim patch -
>> definitely not ready for merge and mostly here to illustrate how the
>> different APIs can be used and to start some discussions how to handle HW
>> specific challenges. Of course if someone wants to play with Extended Key
>> ID they also should be useful... (I can provide updated mostly working
>> hostapd/wpa_supplicant patches if someone is interested.
> 
> Of course :-)

I've just upload my current hostapd patches here:
https://www.awhome.eu/index.php/s/FZx68eGMGbwf6EK

These are slightly updated versions of the patches I send to the hostapd 
mailing list used in my tests. I'm using them since months in mixed 
environments with and without Extennded Key ID support.
Once the nl80211 API stabilizes I'll plan to polish them, fill in the 
known gaps and try to get them merged.

> 
> Some tests for the hwsim tests there would also be nice, that's the
> easiest way to see something working - if you have them.

I did run the the existing PTK tests but proper tests for Extended Key 
ID are the biggest open topic. I suspect proper tests will the most 
complicated open task here.

The others are:
- No support for Extended Key ID in mesh mode
- Update to new kernel API (the one we extended for Extended KEY ID) 
needs some more work.
- Make sure we do not install the keys twice when repeating either EAPOL 
3 or 4 (I think one of them was ok, but I did not look at that for 
ages... It's still working fine, mac80211 detects a duplicate key 
install and just reports success.)

Alexander