Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9EE0C43381 for ; Fri, 22 Feb 2019 21:20:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A6277206BA for ; Fri, 22 Feb 2019 21:20:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726035AbfBVVUg (ORCPT ); Fri, 22 Feb 2019 16:20:36 -0500 Received: from s3.sipsolutions.net ([144.76.43.62]:54424 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725811AbfBVVUg (ORCPT ); Fri, 22 Feb 2019 16:20:36 -0500 Received: by sipsolutions.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92-RC5) (envelope-from ) id 1gxIFG-0006up-Gl; Fri, 22 Feb 2019 22:20:34 +0100 Message-ID: <8a0b0cb563f511be74ccb9a7e491847c87aacc2b.camel@sipsolutions.net> Subject: Re: [RFC PATCH v3 08/12] iwlwifi: dvm - EXT_KEY_ID A-MPDU API update From: Johannes Berg To: Alexander Wetzel Cc: linux-wireless@vger.kernel.org Date: Fri, 22 Feb 2019 22:20:33 +0100 In-Reply-To: <4bd73bd3-9027-4689-54e7-7c082eefa327@wetzel-home.de> References: <20190210210620.31181-1-alexander@wetzel-home.de> <20190210210620.31181-9-alexander@wetzel-home.de> <63fecadcf3f38f24b547143d9d53b3454adc417a.camel@sipsolutions.net> <4bd73bd3-9027-4689-54e7-7c082eefa327@wetzel-home.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-2.fc28) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, 2019-02-22 at 22:15 +0100, Alexander Wetzel wrote: > I hoped that the HW would already enforce the key border. I don't think so. > But ok: The > cards will still be able to use NATIVE mode. Only now the driver will > have to request to disable Tx aggregation when finding a key border. It doesn't really have to even completely disable it, it'd just have to send and LQ_CMD with agg_params.agg_frame_cnt_limit = 1, temporarily, until the relevant frames were transmitted (this is a global config, so it'd have to track the key border on each TID, but that's not _too_ hard). > Since Tx aggregation is disabled per default anyhow many users will not > even see a difference. Good point, I forgot all about that. > (Off topic here, but I suspect the not reproducible problems leading to > change the Tx aggregation default to off could also have been ptk0 rekey > freezes. In that case we could now allow it again. But I've not found > raw error reports and guess it's not worth the efforts/risks to change > the default again.) I wouldn't be so sure - PTK rekeying should still be a pretty uncommon configuration. But I also don't recall the exact decision making going into this. johannes