DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 30E416074F
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@redhat.com>
Cc:     YueHaibing <yuehaibing@huawei.com>,
        QCA ath9k Development <ath9k-devel@qca.qualcomm.com>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ath9k: remove set but not used variable 'acq'
References: <20190225033246.127410-1-yuehaibing@huawei.com>
        <87lg24urgq.fsf@toke.dk>
Date:   Mon, 25 Feb 2019 12:03:16 +0200
In-Reply-To: <87lg24urgq.fsf@toke.dk> ("Toke \=\?utf-8\?Q\?H\=C3\=B8iland-J\?\=
 \=\?utf-8\?Q\?\=C3\=B8rgensen\=22's\?\= message of
        "Mon, 25 Feb 2019 10:50:45 +0100")
Message-ID: <87ftscmbh7.fsf@kamboji.qca.qualcomm.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Toke H=C3=B8iland-J=C3=B8rgensen <toke@redhat.com> writes:

> YueHaibing <yuehaibing@huawei.com> writes:
>
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/net/wireless/ath/ath9k/recv.c: In function 'ath_rx_count_airtime=
':
>> drivers/net/wireless/ath/ath9k/recv.c:1010:18: warning:
>>  variable 'acq' set but not used [-Wunused-but-set-variable]
>>
>> It's not used after 89cea7493a34 ("ath9k: Switch to mac80211 TXQ schedul=
ing
>> and airtime APIs"). Also remove related variables.
>
> Ah, right, seems I forgot to clean that up. I wonder why I didn't get a
> compiler warning for it.

I think the warning is not enabled by default and you need to use W=3D1
Makefile variable to enable it.

--=20
Kalle Valo