Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68DE2C43381 for ; Tue, 26 Feb 2019 13:07:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 357A220651 for ; Tue, 26 Feb 2019 13:07:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="gLzeUkRm"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="MECo782l" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726940AbfBZNHy (ORCPT ); Tue, 26 Feb 2019 08:07:54 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:50754 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726018AbfBZNHy (ORCPT ); Tue, 26 Feb 2019 08:07:54 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 2B80F60FE9; Tue, 26 Feb 2019 13:07:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1551186473; bh=kHtRnYdwFaT9aJ0xp+ceyUdL7YB50HhzOJGiLGDMN3w=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=gLzeUkRmt3CJFYZC7H9K4gVK0ZdDR9HlowTe+abpLKhdEW2KTDGAPJJFXp6lfYizA zDgQGLpPY93AkCNIPXY91hftHMEFiNvtVqYy/XJLiuK97Thc742GPSXSVVxxpRFEEA x+cWe/H3TPykeO3o0TAawpHK34yu1N7qXPPjT5Y0= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 6011C60247; Tue, 26 Feb 2019 13:07:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1551186472; bh=kHtRnYdwFaT9aJ0xp+ceyUdL7YB50HhzOJGiLGDMN3w=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=MECo782lbx0b14MewE72ceW4e/8/auAccs4pBFfkh2VhvFIP5Zn14AOYi/R5XJOyP nfrI994p/1AZF2EYTwg4cQXPDUXTmGAaCyb+wSWdvc7L0ocaJLOCa2jn9SXn2Zl+ni Kw9nndkLZSawolDK5kI27xFsiQvSdL/flTtnQIbs= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6011C60247 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] ath9k: Make sure to zero status.tx_time before reporting TX status From: Kalle Valo In-Reply-To: <20190215164855.30666-1-toke@redhat.com> References: <20190215164855.30666-1-toke@redhat.com> To: =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Cc: make-wifi-fast@lists.bufferbloat.net, linux-wireless@vger.kernel.org, =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190226130753.2B80F60FE9@smtp.codeaurora.org> Date: Tue, 26 Feb 2019 13:07:52 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Toke Høiland-Jørgensen wrote: > Since ath9k reports airtime usage directly using the > ieee80211_report_airtime() callback, it shouldn't also report it using the > tx_time in status. Make sure the field is zeroed before TX status is > reported to avoid spurious airtime being accounted by bits being left over > from earlier uses of the cb. > > Fixes: 89cea7493a34 ("ath9k: Switch to mac80211 TXQ scheduling and airtime APIs") > Signed-off-by: Toke Høiland-Jørgensen > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. cc591d77aba1 ath9k: Make sure to zero status.tx_time before reporting TX status -- https://patchwork.kernel.org/patch/10815445/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches