Date:   Fri, 1 Mar 2019 10:58:53 +0100
From:   Stanislaw Gruszka <sgruszka@redhat.com>
To:     Lorenzo Bianconi <lorenzo@kernel.org>
Cc:     nbd@nbd.name, linux-wireless@vger.kernel.org,
        ryder.lee@mediatek.com, roychl666@gmail.com,
        lorenzo.bianconi@redhat.com
Subject: Re: [RFC 2/2] mt76: introduce mt76_hw_queue data structure
Message-ID: <20190301095852.GA31324@redhat.com>
References: <cover.1551431791.git.lorenzo@kernel.org>
 <e42f2de79766a2bd507d66ea2dabb0e79a684450.1551431791.git.lorenzo@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e42f2de79766a2bd507d66ea2dabb0e79a684450.1551431791.git.lorenzo@kernel.org>
User-Agent: Mutt/1.8.3 (2017-05-23)
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Fri, Mar 01, 2019 at 10:22:04AM +0100, Lorenzo Bianconi wrote:
> -struct mt76_queue {
> +struct mt76_hw_queue {
>  
>  	u16 first;
>  	u16 head;
>  	u16 tail;
> -	int ndesc;
> -	int queued;
> -	int buf_size;
>  
> +	dma_addr_t desc_dma;
> +
> +	int buf_size;
>  	u8 buf_offset;
> +
>  	u8 hw_idx;
>  
> -	dma_addr_t desc_dma;
> -	struct sk_buff *rx_head;
>  	struct page_frag_cache rx_page;
>  	spinlock_t rx_page_lock;
> +	struct sk_buff *rx_head;
> +};
> +
> +struct mt76_queue {
> +	struct mt76_hw_queue *hwq;
> +
> +	struct list_head swq;
> +	int swq_queued;
>  };

I don't think massive renaming is necessary. It makes patch more complex
and eventual future backporting of fixes harder. Simpler approach would
be doing:

struct mt76_sw_queue {
	struct mt76_queue *q;

	struct list_head swq;
	int swq_queued;
}

what should achieve the same goal without massive changes in the code.

Stanislaw