Date:   Fri, 1 Mar 2019 11:31:28 +0100
From:   Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To:     Stanislaw Gruszka <sgruszka@redhat.com>
Cc:     Lorenzo Bianconi <lorenzo@kernel.org>, nbd@nbd.name,
        linux-wireless@vger.kernel.org, ryder.lee@mediatek.com,
        roychl666@gmail.com
Subject: Re: [RFC 2/2] mt76: introduce mt76_hw_queue data structure
Message-ID: <20190301103126.GA16993@localhost.localdomain>
References: <cover.1551431791.git.lorenzo@kernel.org>
 <e42f2de79766a2bd507d66ea2dabb0e79a684450.1551431791.git.lorenzo@kernel.org>
 <20190301095852.GA31324@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="cNdxnHkX5QqsyA0e"
Content-Disposition: inline
In-Reply-To: <20190301095852.GA31324@redhat.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk


--cNdxnHkX5QqsyA0e
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> On Fri, Mar 01, 2019 at 10:22:04AM +0100, Lorenzo Bianconi wrote:
> > -struct mt76_queue {
> > +struct mt76_hw_queue {
> > =20
> >  	u16 first;
> >  	u16 head;
> >  	u16 tail;
> > -	int ndesc;
> > -	int queued;
> > -	int buf_size;
> > =20
> > +	dma_addr_t desc_dma;
> > +
> > +	int buf_size;
> >  	u8 buf_offset;
> > +
> >  	u8 hw_idx;
> > =20
> > -	dma_addr_t desc_dma;
> > -	struct sk_buff *rx_head;
> >  	struct page_frag_cache rx_page;
> >  	spinlock_t rx_page_lock;
> > +	struct sk_buff *rx_head;
> > +};
> > +
> > +struct mt76_queue {
> > +	struct mt76_hw_queue *hwq;
> > +
> > +	struct list_head swq;
> > +	int swq_queued;
> >  };
>=20
> I don't think massive renaming is necessary. It makes patch more complex
> and eventual future backporting of fixes harder. Simpler approach would
> be doing:
>=20
> struct mt76_sw_queue {
> 	struct mt76_queue *q;
>=20
> 	struct list_head swq;
> 	int swq_queued;
> }

ack, it sounds good to me. Anyway mt76_queue is pretty spread as well :(
I will post a v2 squashing this change.

Regards,
Lorenzo

>=20
> what should achieve the same goal without massive changes in the code.
>=20
> Stanislaw

--cNdxnHkX5QqsyA0e
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCXHkJ+wAKCRA6cBh0uS2t
rPrxAP9hESTwLgw3UrTGBlABcvkWqG8I7d7TyiGP0uyKO/LyFQD+NdzJPhbTbWaf
GrvRm88F+bmpKYzXoNmbDcNTkO6YSQo=
=hyCi
-----END PGP SIGNATURE-----

--cNdxnHkX5QqsyA0e--