Subject: Re: [PATCH 3/4] brcmfmac: add a function designated for handling
 firmware fails
To:     =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>,
        Kalle Valo <kvalo@codeaurora.org>
Cc:     linux-wireless@vger.kernel.org,
        brcm80211-dev-list.pdl@broadcom.com,
        brcm80211-dev-list@cypress.com,
        =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>
References: <20190226131119.7907-1-zajec5@gmail.com>
 <20190226131119.7907-4-zajec5@gmail.com>
From:   Arend Van Spriel <arend.vanspriel@broadcom.com>
Message-ID: <a80dca6c-0575-2ae9-9e1f-1382dfbeefb1@broadcom.com>
Date:   Wed, 6 Mar 2019 10:02:37 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.1
MIME-Version: 1.0
In-Reply-To: <20190226131119.7907-4-zajec5@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 2/26/2019 2:11 PM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> This improves handling PCIe firmware halts by printing a clear error
> message and replaces a similar code in the SDIO bus support.
> 
> It will also allow further improvements like trying to recover from a
> firmware crash.

Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
>   drivers/net/wireless/broadcom/brcm80211/brcmfmac/bus.h |  2 ++
>   .../net/wireless/broadcom/brcm80211/brcmfmac/core.c    | 10 ++++++++++
>   .../net/wireless/broadcom/brcm80211/brcmfmac/pcie.c    |  2 +-
>   .../net/wireless/broadcom/brcm80211/brcmfmac/sdio.c    |  4 ++--
>   4 files changed, 15 insertions(+), 3 deletions(-)