Subject: Re: [PATCH 4/4] brcmfmac: reset PCIe bus on a firmware crash
To:     =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>,
        Kalle Valo <kvalo@codeaurora.org>
Cc:     linux-wireless@vger.kernel.org,
        brcm80211-dev-list.pdl@broadcom.com,
        brcm80211-dev-list@cypress.com,
        =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>
References: <20190226131119.7907-1-zajec5@gmail.com>
 <20190226131119.7907-5-zajec5@gmail.com>
From:   Arend Van Spriel <arend.vanspriel@broadcom.com>
Message-ID: <b33340cc-20ac-9bae-7735-1849dab06a27@broadcom.com>
Date:   Wed, 6 Mar 2019 10:08:52 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.1
MIME-Version: 1.0
In-Reply-To: <20190226131119.7907-5-zajec5@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk


On 2/26/2019 2:11 PM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> This includes bus reset & reloading a firmware. It should be sufficient
> for a user space to (setup and) use a wireless device again.
> 
> Support for reset on USB & SDIO can be added later.

It should be noted that you end up with a new wiphy instance though. We 
could try to avoid that in subsequent change.

Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
>   .../broadcom/brcm80211/brcmfmac/bus.h         | 10 ++++++
>   .../broadcom/brcm80211/brcmfmac/core.c        | 12 +++++++
>   .../broadcom/brcm80211/brcmfmac/core.h        |  2 ++
>   .../broadcom/brcm80211/brcmfmac/pcie.c        | 35 +++++++++++++++++++
>   4 files changed, 59 insertions(+)