Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C4C0C43381 for ; Wed, 6 Mar 2019 11:03:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1005220675 for ; Wed, 6 Mar 2019 11:03:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729177AbfCFLDd (ORCPT ); Wed, 6 Mar 2019 06:03:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49388 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728992AbfCFLDc (ORCPT ); Wed, 6 Mar 2019 06:03:32 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9629A3082E46; Wed, 6 Mar 2019 11:03:32 +0000 (UTC) Received: from localhost (ovpn-204-204.brq.redhat.com [10.40.204.204]) by smtp.corp.redhat.com (Postfix) with ESMTP id EC521611C3; Wed, 6 Mar 2019 11:03:31 +0000 (UTC) Date: Wed, 6 Mar 2019 12:03:30 +0100 From: Stanislaw Gruszka To: Lorenzo Bianconi Cc: Xose Vazquez Perez , Felix Fietkau , Lorenzo Bianconi , linux-wireless , Jakub Kicinski , Hans Ulli Kroll Subject: Re: mediatek: duplicate usb devices Message-ID: <20190306110329.GD12946@redhat.com> References: <11161578-bb42-168b-1459-f22a98f5c6bb@gmail.com> <20190306075053.GA12946@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Wed, 06 Mar 2019 11:03:32 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, Mar 06, 2019 at 11:09:12AM +0100, Lorenzo Bianconi wrote: > > > > On Tue, Mar 05, 2019 at 07:33:51PM +0100, Xose Vazquez Perez wrote: > > > There a three duplicate devices at: > > > > > > mt76/mt76x2/usb.c: { USB_DEVICE(0x0e8d, 0x7612) }, /* Alfa AWUS036ACM */ > > > mt76/mt76x2/usb.c: { USB_DEVICE(0x0e8d, 0x7612) }, /* Aukey USB-AC1200 */ > > One duplicated entry should be removed. > > > > > mt76/mt76x0/usb.c: { USB_DEVICE(0x148f, 0x760a) }, /* TP-Link unknown */ > > > mt7601u/usb.c: { USB_DEVICE(0x148f, 0x760a) }, > > IIUC this is not in the mt7601u driver available on mtk website. The same apply to mt7610u. Vendor driver have only IDs for some reference devices. Both mt7601u and mt7610u drivers do not include 0x7610. For mt76x0u ids were provided by Hans https://lore.kernel.org/linux-wireless/alpine.LNX.2.00.1804092042320.8369@T420s/ I'm not sure where they came from. Stanislaw