Date:   Fri, 8 Mar 2019 14:00:21 +0100
From:   Stanislaw Gruszka <sgruszka@redhat.com>
To:     Kalle Valo <kvalo@codeaurora.org>
Cc:     Tony Chuang <yhchuang@realtek.com>,
        "johannes@sipsolutions.net" <johannes@sipsolutions.net>,
        "Larry.Finger@lwfinger.net" <Larry.Finger@lwfinger.net>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        Pkshih <pkshih@realtek.com>, Andy Huang <tehuang@realtek.com>,
        "briannorris@chromium.org" <briannorris@chromium.org>
Subject: Re: [PATCH v2 00/24] rtw88: major fixes for 8822c to have stable
 functionalities
Message-ID: <20190308130021.GA4108@redhat.com>
References: <1550134743-17443-1-git-send-email-yhchuang@realtek.com>
 <F7CD281DE3E379468C6D07993EA72F84D17AE4FD@RTITMBSVM04.realtek.com.tw>
 <87a7i58xag.fsf@kamboji.qca.qualcomm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87a7i58xag.fsf@kamboji.qca.qualcomm.com>
User-Agent: Mutt/1.8.3 (2017-05-23)
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Fri, Mar 08, 2019 at 12:39:51PM +0200, Kalle Valo wrote:
> Once everyone are happy about the driver, at least it needs a review
> from Johannes and me but reviews from others is more than welcome. I
> also saw that Brian gave good comments but not sure if he thinks the
> driver is ready for upstream?
> 
> An ideal schedule is to apply the driver just after the -rc1 is release,
> so within two weeks time. That way we have maximum time to fix any
> problems which might arise.
> 
> Did Stanislaw already review this driver? I don't see any mentioning of
> that in the cover letter[1].

I haven't done that for v3 and later, but v2 of rtw88 was more or less
ok for me (did not see anything wrong that could not be fixed after
inclusion). Anyway, happy to do the review if it helps to merge the
driver.

Stanislaw