Date:   Fri, 8 Mar 2019 18:24:26 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Larry Finger <Larry.Finger@lwfinger.net>
Cc:     yhchuang@realtek.com, kvalo@codeaurora.org,
        johannes@sipsolutions.net, linux-wireless@vger.kernel.org,
        sgruszka@redhat.com, pkshih@realtek.com, tehuang@realtek.com,
        briannorris@chromium.org
Subject: Re: [PATCH v6 14/14] staging: rtlwifi: remove staging rtlwifi driver
Message-ID: <20190308172426.GA20723@kroah.com>
References: <1552053343-6513-1-git-send-email-yhchuang@realtek.com>
 <1552053343-6513-15-git-send-email-yhchuang@realtek.com>
 <20190308140619.GE25768@kroah.com>
 <f69bd329-f974-7f82-11dd-c864ee283762@lwfinger.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f69bd329-f974-7f82-11dd-c864ee283762@lwfinger.net>
User-Agent: Mutt/1.11.3 (2019-02-01)
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Fri, Mar 08, 2019 at 11:20:11AM -0600, Larry Finger wrote:
> On 3/8/19 8:06 AM, Greg KH wrote:
> > On Fri, Mar 08, 2019 at 09:55:43PM +0800, yhchuang@realtek.com wrote:
> > > From: Yan-Hsuan Chuang <yhchuang@realtek.com>
> > > 
> > > The rtlwifi driver is conflicting with Realtek's new 802.11ac chip
> > > series driver rtw88, remove it to avoid racing with the same ID.
> > > 
> > > The rtw88 driver can be found at drivers/net/wireless/realtek/rtw88
> > 
> > The only objection I have here is that your new driver does not support
> > all of the devices that this driver does.  So why not just rip out the
> > PCI stuff for the staging driver until the USB/SDIO code gets added to
> > the new one, and then you can drop the rest of this code?
> 
> Greg,
> 
> The staging driver only supports PCI ID 0x10ec:0xB822, whereas the new one
> supports that ID plus 0x10ec:0xC822. There will not be any devices dropped
> when the staging code is deleted as long as the new driver is added.

Ah, ok, all of those "*usb*" files in that driver directory lied :)

If there's no regression of devices, then I have no objection to this:

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

thanks,

greg k-h