Date:   Mon, 11 Mar 2019 15:02:56 +0100
From:   Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To:     Stanislaw Gruszka <sgruszka@redhat.com>
Cc:     Lorenzo Bianconi <lorenzo@kernel.org>, nbd@nbd.name,
        ryder.lee@mediatek.com, roychl666@gmail.com,
        linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/4] mt76: move mt76x02_insert_hdr_pad in mt76-core module
Message-ID: <20190311140255.GA30882@localhost.localdomain>
References: <cover.1552306908.git.lorenzo@kernel.org>
 <0ec618f40f6308f4da8c6a766519dfd66fa5ad57.1552306908.git.lorenzo@kernel.org>
 <20190311133058.GC6089@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="SUOF0GtieIMvvwua"
Content-Disposition: inline
In-Reply-To: <20190311133058.GC6089@redhat.com>
User-Agent: Mutt/1.11.3 (2019-02-01)
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk


--SUOF0GtieIMvvwua
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> On Mon, Mar 11, 2019 at 01:35:23PM +0100, Lorenzo Bianconi wrote:
> > +static inline int mt76_insert_hdr_pad(struct sk_buff *skb)
> > +{
> > +	int len =3D ieee80211_get_hdrlen_from_skb(skb);
> > +
> > +	if (len % 4 =3D=3D 0)
> > +		return 0;
> > +
> > +	skb_push(skb, 2);
> > +	memmove(skb->data, skb->data + 2, len);
> > +
> > +	skb->data[len] =3D 0;
> > +	skb->data[len + 1] =3D 0;
> > +	return 2;
> > +}
> <snip>
> > @@ -165,7 +165,7 @@ int mt76x02_tx_prepare_skb(struct mt76_dev *mdev, v=
oid *txwi_ptr,
> >  	pid =3D mt76_tx_status_skb_add(mdev, wcid, skb);
> >  	txwi->pktid =3D pid;
> > =20
> > -	ret =3D mt76x02_insert_hdr_pad(skb);
> > +	ret =3D mt76_insert_hdr_pad(skb);
> >  	if (ret < 0)
> >  		return ret;
>=20
> Since you modify this you can make mt76_inser_hdr_pad() return
> void since we do not return error any longer.

ack, will do in v2

Regards,
Lorenzo

>=20
> Stanislaw

--SUOF0GtieIMvvwua
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCXIZqiwAKCRA6cBh0uS2t
rBgyAP9pKYDMcambobo/jrTWCDASjrQkyPYI5Ux7j4CB5UGHqQEA3N5BvhWi3bc9
bb5tzCIAaE0Cois8XjAnlvhymiZnWgk=
=ylfc
-----END PGP SIGNATURE-----

--SUOF0GtieIMvvwua--