DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 7C5E36019F
From:   Kalle Valo <kvalo@codeaurora.org>
To:     <yhchuang@realtek.com>
Cc:     <johannes@sipsolutions.net>, <gregkh@linuxfoundation.org>,
        <linux-wireless@vger.kernel.org>, <Larry.Finger@lwfinger.net>,
        <sgruszka@redhat.com>, <pkshih@realtek.com>, <tehuang@realtek.com>,
        <briannorris@chromium.org>
Subject: Re: [PATCH v7 00/14] rtw88: mac80211 driver for Realtek 802.11ac wireless network chips
References: <1552139302-20476-1-git-send-email-yhchuang@realtek.com>
Date:   Tue, 12 Mar 2019 07:14:19 +0200
In-Reply-To: <1552139302-20476-1-git-send-email-yhchuang@realtek.com>
        (yhchuang@realtek.com's message of "Sat, 9 Mar 2019 21:48:08 +0800")
Message-ID: <87ef7cznbo.fsf@purkki.adurom.net>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

<yhchuang@realtek.com> writes:

> From: Yan-Hsuan Chuang <yhchuang@realtek.com>
>
> This is a new mac80211 driver for Realtek 802.11ac wireless network chips.
> rtw88 now supports RTL8822BE/RTL8822CE now, with basic station mode
> functionalities. The firmware for both can be found at linux-firmware.
>
> https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git
> For RTL8822BE: rtw88/rtw8822b_fw.bin
> For RTL8822CE: rtw88/rtw8822c_fw.bin
>
> And for now, only PCI buses (RTL8xxxE) are supported. We will add support
> for USB and SDIO in the future. The bus interface abstraction can be seen
> in this driver such as hci.h. Most of the hardware setting are the same
> except for some TRX path or probing setup should be separated.
>
> Supported:
>
>  * Basic STA/AP/ADHOC mode, and TDLS (STA is well tested)
>
> Missing feature:
>
>  * WOW/PNO
>  * USB & SDIO bus (such as RTL8xxxU/RTL8xxxS)
>  * BT coexistence (8822B/8822C are combo ICs)
>  * Multiple interfaces (for now single STA is better supported)
>  * Dynamic hardware calibrations (to improve/stabilize performance)
>
> Potential problems:
>
>  * static calibration spends too much time, and it is painful for
>    driver to leave IDLE state. And slows down associate process.
>    But reload function are under development, will be added soon!
>  * TRX statictics misleading, as we are not reporting status correctly,
>    or say, not reporting for "every" packet.
>
>
> The next patch set should have BT coexistence code since RTL8822B/C are
> combo ICs, and the driver for BT can be found after Linux Kernel v4.20.
> So it is better to add it first to make WiFi + BT work concurrently.
>
> Although now rtw88 is simple but we are developing more features for it.
> Even we want to add support for more chips such as RTL8821C/RTL8814B.

As we are getting closer to getting the driver accepted first few ground
rules to simplify the review: please don't send a new version until I
explicitly ask for it. Also don't make any changes to the driver unless
explicitly asked by Johannes or me, all other cleanup can be submitted
as followup patches after the driver is accepted.

I applied this now to the pending branch[1] and kbuild bot found one
problem, please fix that in the next version:

tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git pending
head:   d5ae36c5064e6c036d86da20b5835df5225ba9ff
commit: 72a54e89a08d8747360b4c731c41871e22b6d84e [44/54] rtw88: add 8822c tx agc support
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-8 (Debian 8.3.0-2) 8.3.0
reproduce:
        git checkout 72a54e89a08d8747360b4c731c41871e22b6d84e
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

>> ld: drivers/net/wireless/realtek/rtw88/phy.o:(.data+0x360):
>> multiple definition of `cck_rates';
>> drivers/net/wireless/broadcom/brcm80211/brcmsmac/rate.o:(.rodata+0x60):
>> first defined here
>> ld: drivers/net/wireless/realtek/rtw88/phy.o:(.data+0x320):
>> multiple definition of `ofdm_rates';
>> drivers/net/wireless/broadcom/brcm80211/brcmsmac/rate.o:(.rodata+0xc0):
>> first defined here

-- 
Kalle Valo