Message-ID: <0cf2145dcbdae5c94beefea7f6681be325e0bbd1.camel@intel.com>
Subject: Re: [PATCH 06/16] mac80211_hwsim: make copying of ciphers safer by
 checking the length
From:   Luciano Coelho <luciano.coelho@intel.com>
To:     kvalo@codeaurora.org, johannes@sipsolutions.net
Cc:     linux-wireless@vger.kernel.org
Date:   Fri, 15 Mar 2019 18:40:47 +0200
In-Reply-To: <20190315163634.17315-7-luca@coelho.fi>
References: <20190315163634.17315-1-luca@coelho.fi>
         <20190315163634.17315-7-luca@coelho.fi>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.30.5-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Fri, 2019-03-15 at 18:36 +0200, Luca Coelho wrote:
> From: Luca Coelho <luciano.coelho@intel.com>
> 
> Make sure the length of the ciphers we are copying never exceeds the
> space we have for storing them.  There is no risk of overcopying at
> the moment, because we check n_params before, but this makes this
> function safer in case someone changes something in the future.
> 
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> ---

Ooops, this one should obviously not go through my tree.  Johannes, can
you please take it? I've removed from my tree and won't include it as
part of my pull-request.

I'll also check patchwork and make sure it's under Johannes' name.

--
Cheers,
Luca.