MIME-Version: 1.0
References: <1553005870-28018-1-git-send-email-chongguiguzi@gmail.com> <1553049084.13542.2.camel@realtek.com>
In-Reply-To: <1553049084.13542.2.camel@realtek.com>
From:   =?UTF-8?B?6LCi5qyi?= <chongguiguzi@gmail.com>
Date:   Wed, 20 Mar 2019 10:41:54 +0800
Message-ID: <CAJ3e5OY-vuuenepfugTwZesksAhzAjHC8rENKcrWLJTqiYm8=Q@mail.gmail.com>
Subject: Re: [PATCH] net:rtlwifi:move spin_lock_bh to spin_lock in tasklet
To:     Pkshih <pkshih@realtek.com>
Cc:     "kvalo@codeaurora.org" <kvalo@codeaurora.org>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Thank you so much for your useful advice.

Pkshih <pkshih@realtek.com> =E4=BA=8E2019=E5=B9=B43=E6=9C=8820=E6=97=A5=E5=
=91=A8=E4=B8=89 =E4=B8=8A=E5=8D=8810:31=E5=86=99=E9=81=93=EF=BC=9A
>
> On Tue, 2019-03-19 at 22:31 +0800, Jeff Xie wrote:
> > It is unnecessary to call spin_lock_bh in a tasklet.
> >
> > Signed-off-by: Jeff Xie <chongguiguzi@gmail.com>
> >
> > ---
> >  drivers/net/wireless/realtek/rtlwifi/pci.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/wireless/realtek/rtlwifi/pci.c
> > b/drivers/net/wireless/realtek/rtlwifi/pci.c
> > index 48ca521..4055e0a 100644
> > --- a/drivers/net/wireless/realtek/rtlwifi/pci.c
> > +++ b/drivers/net/wireless/realtek/rtlwifi/pci.c
> > @@ -499,16 +499,16 @@ static void _rtl_pci_tx_chk_waitq(struct ieee8021=
1_hw
> > *hw)
> >
> >                       memset(&tcb_desc, 0, sizeof(struct rtl_tcb_desc))=
;
> >
> > -                     spin_lock_bh(&rtlpriv->locks.waitq_lock);
> > +                     spin_lock(&rtlpriv->locks.waitq_lock);
> >                       if (!skb_queue_empty(&mac->skb_waitq[tid]) &&
> >                           (ring->entries - skb_queue_len(&ring->queue) =
>
> >                            rtlhal->max_earlymode_num)) {
> >                               skb =3D skb_dequeue(&mac->skb_waitq[tid])=
;
> >                       } else {
> > -                             spin_unlock_bh(&rtlpriv->locks.waitq_lock=
);
> > +                             spin_unlock(&rtlpriv->locks.waitq_lock);
> >                               break;
> >                       }
> > -                     spin_unlock_bh(&rtlpriv->locks.waitq_lock);
> > +                     spin_unlock(&rtlpriv->locks.waitq_lock);
> >
> >                       /* Some macaddr can't do early mode. like
> >                        * multicast/broadcast/no_qos data
>
> The mail subject should be 'rtlwifi: move ....', and the other looks good=
 to me.
>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
>
>