From:   Sven Eckelmann <sven@narfation.org>
To:     Tom Psyborg <pozega.tomislav@gmail.com>
Cc:     linux-wireless@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>,
        QCA ath9k Development <ath9k-devel@qca.qualcomm.com>
Subject: Re: [PATCH] ath9k: Differentiate between max combined and per chain power
Date:   Wed, 20 Mar 2019 18:25:43 +0100
Message-ID: <1693082.M5RyE5W9Oo@bentobox>
In-Reply-To: <CAKR_QV+eHK4FN6V5aduS9vc8Zd2kbK5Ry3NO35Q1BwY58arZug@mail.gmail.com>
References: <20190320103723.27228-1-sven@narfation.org> <CAKR_QV+eHK4FN6V5aduS9vc8Zd2kbK5Ry3NO35Q1BwY58arZug@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart2242750.p2HVIC31lz"; micalg="pgp-sha512"; protocol="application/pgp-signature"
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

--nextPart2242750.p2HVIC31lz
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

On Wednesday, 20 March 2019 14:49:57 CET Tom Psyborg wrote:
> On 20/03/2019, Sven Eckelmann <sven@narfation.org> wrote:
> 
> > This also means that a device with multiple tx chains is even limited
> > further:
> >
> > * 1 chain:  31 dBm per chain
> > * 2 chains: 28 dBm per chain
> > * 3 chains: 26 dBm per chain
> >
> 
> This is flawed theory and should be reverted instead of making further
> complications. Simplest way would be to remove
> POWER_CORRECTION_FOR_TWO_CHAIN and POWER_CORRECTION_FOR_THREE_CHAIN;
> from driver

You can of course propose a patch for that. But I will not participate in the 
discussion how EIRP should be measured (per antenna/per system, on max point/
via integral over all positions, ...).

And you should also discuss it with QCA to find out whether they will also 
remove the power correction from their closed source firmware. At least it 
would also affect ath10k... maybe even their other drivers with closed source 
components.

And your change would also not completely supersede my change. You forget that 
the antennagain reduction is also done by scaled ath9k_hw_get_scaled_power.

Kind regards,
	Sven
--nextPart2242750.p2HVIC31lz
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEF10rh2Elc9zjMuACXYcKB8Eme0YFAlySd5cACgkQXYcKB8Em
e0Y8FhAA1dP+Tj72QHRSaJgmQbDxAljz6n+ArmlBFTIfaXq+sxeq5egL+MHxxAoK
5bzEj1F5WfjnueVLWoq+V9SAIW8B8ABmlfjxNUHbHtb+n4mVTmX/aZe9JFXSOhER
bh8c83CSYKnQQtuPqZk/dkjfJHJbRrNysLIKDXBZvXVYGqSfgyXt+WLLRdRVKgwl
BaCoAO0qyIm2NiThAIkDzaD5+zAaGa0uYfPyLFXSZYZNcnxxSsE3AvMdHcxkZY/7
ZL8eeiUZPsPBIrBYtS7jRMMw/cSH1NIlZXpL+EoZoPTjia5kEFkf5sIfc+RvW+EY
CoS/qiXSfSlS/Bx40e1+0rubVVUSuNoWsDY2GISHU1LW0HLQxj0Gj/oM3aBQio4G
AZm4bys9u6SDmJRyYQ7MZq7mg1JMs4o+KN15Js82oscx1kXy0/iCJQ/XOivV75Z4
Sq9aPFSUbkjRv5iy7ZDuAc0W2Mv8XB3e65BtCMNbMxBDfb/0F0pdrSUJHsXsEIya
NYAKxFiAEbWUwGGmWat946qPB5OSjVgNGbz/qOHowOV8ePe+o9gdYX1eorHDmWsr
ALV2o7kw/ms+z6s2/dW1RA0p/Jn2tR93l4vUqDfZ1R2UN0+O36X26B5xMTRhbbwM
fNvXfPJftpT9diu3fFDyY1N0mTgb80ahKiKLqyS5lMFcawllpL4=
=GQU8
-----END PGP SIGNATURE-----

--nextPart2242750.p2HVIC31lz--